From: Jens Freimann <jfreiman@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "Wang, Zhihong" <zhihong.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count
Date: Wed, 24 May 2017 10:36:01 +0200 [thread overview]
Message-ID: <20170524083601.sd7sueoskpfeyxt7@dhcp-192-218.str.redhat.com> (raw)
In-Reply-To: <20170524081419.GU2276@yliu-dev>
On Wed, May 24, 2017 at 04:14:19PM +0800, Yuanhan Liu wrote:
> On Tue, May 23, 2017 at 12:51:56PM +0000, Wang, Zhihong wrote:
> >
> >
> > > -----Original Message-----
> > > From: Jens Freimann [mailto:jfreiman@redhat.com]
> > > Sent: Tuesday, May 23, 2017 7:54 PM
> > > To: Wang, Zhihong <zhihong.wang@intel.com>
> > > Cc: dev@dpdk.org; yuanhan.liu@linux.intel.com
> > > Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count
> > >
> > > On Mon, May 22, 2017 at 04:01:08PM -0400, Zhihong Wang wrote:
> > > > This patch implements the ops rx_queue_count for vhost PMD by adding
> > > > a helper function rte_vhost_rx_queue_count in vhost lib.
> > > >
> > > > The ops ops rx_queue_count gets vhost RX queue avail count and helps
> > >
> > > s/ops ops/ops/ ?
> >
> > Thanks a lot!
>
> Seems you overlooked other comments, such as:
>
> > > > + vq = dev->virtqueue[qid];
> > >
> > > check for vq == NULL?
> > >
> > > regards,
> > > Jens
>
> Besides, Jens, I'm not a big fan of "dev == NULL" over "!dev". I accept
> both :)
Personally I'm with you on this, but it says different in http://dpdk.org/doc/guides/contributing/coding_style.html
Anyway, up to you :)
regards,
Jens
next prev parent reply other threads:[~2017-05-24 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 20:01 Zhihong Wang
2017-05-23 11:53 ` Jens Freimann
2017-05-23 12:51 ` Wang, Zhihong
2017-05-24 8:14 ` Yuanhan Liu
2017-05-24 8:36 ` Jens Freimann [this message]
2017-05-24 8:42 ` Yuanhan Liu
2017-05-26 4:35 ` Wang, Zhihong
2017-05-23 13:10 ` Loftus, Ciara
2017-05-24 0:54 ` [dpdk-dev] [PATCH v2] " Zhihong Wang
2017-05-26 17:18 ` [dpdk-dev] [PATCH v3] " Zhihong Wang
2017-05-26 5:54 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524083601.sd7sueoskpfeyxt7@dhcp-192-218.str.redhat.com \
--to=jfreiman@redhat.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).