From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Moti Haimovsky <motih@mellanox.com>
Cc: dev@dpdk.org, vasilyf@mellanox.com
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: support user space rxq interrupt event
Date: Tue, 30 May 2017 15:29:32 +0200 [thread overview]
Message-ID: <20170530132932.GB1758@6wind.com> (raw)
In-Reply-To: <1495987898-70002-2-git-send-email-motih@mellanox.com>
On Sun, May 28, 2017 at 07:11:38PM +0300, Moti Haimovsky wrote:
> Implement rxq interrupt callbacks
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Hi Moti,
While this patch is almost identical to its mlx5 counterpart, I have one
minor nit (see below). Besides that:
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
> doc/guides/nics/features/mlx4.ini | 1 +
> doc/guides/rel_notes/release_17_08.rst | 5 +
> drivers/net/mlx4/mlx4.c | 218 ++++++++++++++++++++++++++++++++-
> drivers/net/mlx4/mlx4.h | 1 +
> 4 files changed, 219 insertions(+), 6 deletions(-)
[...]
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index ec4419a..95ab325 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -75,6 +75,7 @@
> #include <rte_memory.h>
> #include <rte_flow.h>
> #include <rte_kvargs.h>
> +#include <rte_interrupts.h>
>
> /* Generated configuration header. */
> #include "mlx4_autoconf.h"
> @@ -127,6 +128,30 @@ struct mlx4_conf {
> NULL,
> };
>
> +static void
> +mlx4_dev_link_status_handler(void *);
> +
> +static void
> +mlx4_dev_interrupt_handler(void *);
> +
I understand the need for a clean up, however these definitions are not
related to this patch.
[...]
>
> -static void
> -mlx4_dev_link_status_handler(void *);
> -static void
> -mlx4_dev_interrupt_handler(void *);
> -
Please leave them here.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-05-30 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 15:11 [dpdk-dev] [PATCH] " Moti Haimovsky
2017-05-28 16:09 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
2017-05-28 16:11 ` Moti Haimovsky
2017-05-28 16:11 ` Moti Haimovsky
2017-05-30 13:29 ` Adrien Mazarguil [this message]
2017-06-06 14:48 ` [dpdk-dev] [PATCH v3] " Moti Haimovsky
2017-06-06 14:48 ` Moti Haimovsky
2017-06-07 9:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530132932.GB1758@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=motih@mellanox.com \
--cc=vasilyf@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).