From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: john.mcnamara@intel.com, nelio.laranjeiro@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: add VLAN flow limitation on mlx5 PMD
Date: Mon, 12 Jun 2017 16:27:35 +0200 [thread overview]
Message-ID: <20170612142735.GD1758@6wind.com> (raw)
In-Reply-To: <20170606142016.140162-1-shahafs@mellanox.com>
Hi Shahaf,
On Tue, Jun 06, 2017 at 05:20:16PM +0300, Shahaf Shuler wrote:
> On mlx5 PMD Flow pattern without any specific vlan will match for vlan
> packets as well.
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Nelio Laranjeiro nelio.laranjeiro@6wind.com
> ---
> doc/guides/rel_notes/release_17_08.rst | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst
> index 7f1212094..bd219640c 100644
> --- a/doc/guides/rel_notes/release_17_08.rst
> +++ b/doc/guides/rel_notes/release_17_08.rst
> @@ -111,6 +111,22 @@ Known Issues
> Also, make sure to start the actual text at the margin.
> =========================================================
>
> +* **On mlx5 PMD, Flow pattern without any specific vlan will match for vlan packets as well.**
> +
> + When VLAN spec is not specified in the pattern, the matching rule will be created with VLAN as a wild card.
> + Meaning, the flow rule::
> +
> + flow create 0 ingress pattern eth / vlan vid is 3 / ipv4 / end ...
> +
> + Will only match vlan packets with vid=3. and the flow rules::
> +
> + flow create 0 ingress pattern eth / ipv4 / end ...
> +
> + Or::
> +
> + flow create 0 ingress pattern eth / vlan / ipv4 / end ...
> +
> + Will match any ipv4 packet (VLAN included).
>
> API Changes
> -----------
I do not think this should be part of the release notes as it is not a new
behavior introduced by a commit for 17.08. It has been the case since VLAN
support was added to the mlx5 rte_flow implementation back in 17.02.
Please move this info to guide/nics/mlx5.rst, the resulting documentation
commit should likely be CC'ed to stable@dpdk.org against "net/mlx5: support
VLAN flow item".
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-06-12 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 14:20 Shahaf Shuler
2017-06-12 14:27 ` Adrien Mazarguil [this message]
2017-06-13 10:20 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
2017-06-15 13:44 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612142735.GD1758@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).