From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 4/5] net/mlx5: fix build with gcc 7.1
Date: Wed, 14 Jun 2017 15:24:14 +0200 [thread overview]
Message-ID: <20170614132414.GN1758@6wind.com> (raw)
In-Reply-To: <20170613164212.42374-4-ferruh.yigit@intel.com>
On Tue, Jun 13, 2017 at 05:42:11PM +0100, Ferruh Yigit wrote:
> build error:
> .../dpdk/drivers/net/mlx5/mlx5_fdir.c:
> In function ‘fdir_filter_to_flow_desc’:
> .../dpdk/drivers/net/mlx5/mlx5_fdir.c:146:18:
> error: this statement may fall through [-Werror=implicit-fallthrough=]
> desc->dst_port = fdir_filter->input.flow.udp4_flow.dst_port;
> ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> .../dpdk/drivers/net/mlx5/mlx5_fdir.c:147:2: note: here
> case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER:
> ^~~~
>
> Fixed by adding fallthrough comment to the code.
>
> Fixes: 76f5c99e6840 ("mlx5: support flow director")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> drivers/net/mlx5/mlx5_fdir.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx5/mlx5_fdir.c b/drivers/net/mlx5/mlx5_fdir.c
> index 1cff41bab..c8d47489f 100644
> --- a/drivers/net/mlx5/mlx5_fdir.c
> +++ b/drivers/net/mlx5/mlx5_fdir.c
> @@ -144,6 +144,7 @@ fdir_filter_to_flow_desc(const struct rte_eth_fdir_filter *fdir_filter,
> case RTE_ETH_FLOW_NONFRAG_IPV4_TCP:
> desc->src_port = fdir_filter->input.flow.udp4_flow.src_port;
> desc->dst_port = fdir_filter->input.flow.udp4_flow.dst_port;
> + /* fallthrough */
> case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER:
> desc->src_ip[0] = fdir_filter->input.flow.ip4_flow.src_ip;
> desc->dst_ip[0] = fdir_filter->input.flow.ip4_flow.dst_ip;
That's a fine workaround, therefore:
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
On a personal note though, GCC, seriously? While I understand missing breaks
inside switch statements is a common mistake, having the compiler rely on a
comment that basically says "yes, it's done on purpose" just doesn't feel
right; compilers should discard comments and not attempt to interpret them,
otherwise they have to deal with locale-related issues. It's like enforcing
checkpatch.pl rules in GCC by default. Anyway, back to work.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-06-14 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 16:42 [dpdk-stable] [PATCH 1/5] kni: " Ferruh Yigit
2017-06-13 16:42 ` [dpdk-stable] [PATCH 2/5] net/i40e: fix memset size Ferruh Yigit
2017-06-14 1:15 ` Xing, Beilei
2017-06-13 16:42 ` [dpdk-stable] [PATCH 3/5] net/enic: fix build with gcc 7.1 Ferruh Yigit
2017-06-13 16:42 ` [dpdk-stable] [PATCH 4/5] net/mlx5: " Ferruh Yigit
2017-06-14 13:24 ` Adrien Mazarguil [this message]
2017-06-13 16:42 ` [dpdk-stable] [PATCH 5/5] hash: fix icc build Ferruh Yigit
2017-06-14 20:55 ` [dpdk-stable] [dpdk-dev] [PATCH 1/5] kni: fix build with gcc 7.1 Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614132414.GN1758@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).