DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: jingjing.wu@intel.com, wenzhuo.lu@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: always build VF and MACsec functions
Date: Tue, 20 Jun 2017 14:53:22 +0800	[thread overview]
Message-ID: <20170620065322.GA12786@debian-ZGViaWFuCg> (raw)
In-Reply-To: <20170615110221.1395-1-thomas@monjalon.net>

On Thu, Jun 15, 2017 at 01:02:21PM +0200, Thomas Monjalon wrote:
> These functions are supported only on ixgbe.
[...]
> @@ -3013,15 +3013,21 @@ set_vf_traffic(portid_t port_id, uint8_t is_rx, uint16_t vf, uint8_t on)
>  
>  	if (diag == 0)
>  		return;
> -	if(is_rx)
> +	if(is_rx) {

It's better to also fix this coding style issue.

Best regards,
Tiwei Bie

>  		printf("rte_pmd_ixgbe_set_vf_rx for port_id=%d failed "
> -	       		"diag=%d\n", port_id, diag);
> -	else
> +				"diag=%d\n", port_id, diag);
> +		return;
> +	} else {
>  		printf("rte_pmd_ixgbe_set_vf_tx for port_id=%d failed "
> -	       		"diag=%d\n", port_id, diag);
> -
> -}
> +				"diag=%d\n", port_id, diag);
> +		return;
> +	}
>  #endif
> +	printf("VF %s setting not supported for port %d\n",
> +			is_rx ? "Rx" : "Tx", port_id);
> +	RTE_SET_USED(vf);
> +	RTE_SET_USED(on);
> +}
>  
>  int
>  set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate)
> -- 
> 2.13.1
> 

  parent reply	other threads:[~2017-06-20  6:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 11:02 Thomas Monjalon
2017-06-20  1:01 ` Wu, Jingjing
2017-06-20  7:32   ` Thomas Monjalon
2017-06-20  6:53 ` Tiwei Bie [this message]
2017-06-20  7:31   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620065322.GA12786@debian-ZGViaWFuCg \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).