From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: declan.doherty@intel.com, thomas@monjalon.net
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: [dpdk-dev] [PATCH v2 0/4] Socket ID check removal
Date: Wed, 21 Jun 2017 06:07:29 +0100 [thread overview]
Message-ID: <20170621050733.88850-1-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <20170620232555.82244-1-pablo.de.lara.guarch@intel.com>
Several libraries, drivers and tests check if a socket
is within the range of available sockets, by
implementig their own function, which returns the total
number of sockets that have memory.
First of all, this function is not completely correct,
as it really returns the highest socket id that has memory.
So, if all the sockets up to that one has memory, then it
really returns the total number of sockets with memory,
but if there is at least one in the middle without memory,
then total number of sockets should be less than the value returned.
Besides, this function is not really useful, as the main goal is
to check if memory on a specific socket is available, rather than
checking if a socket id is beyond the total number of sockets.
Therefore, it is better to remove the check and let the memory
allocation function handle an incorrect socket.
Changes in v2:
- Removed new EAL function and just removed the socket id check,
instead of creating a new function.
Pablo de Lara (4):
cryptodev: remove socket id check
crypto/scheduler: remove socket id check
net/bonding: remove socket id check
test/bonding: remove socket id check
drivers/crypto/scheduler/scheduler_pmd.c | 22 ----------------------
drivers/net/bonding/rte_eth_bond_api.c | 16 ----------------
drivers/net/bonding/rte_eth_bond_args.c | 4 ++--
drivers/net/bonding/rte_eth_bond_pmd.c | 6 ------
drivers/net/bonding/rte_eth_bond_private.h | 3 ---
lib/librte_cryptodev/rte_cryptodev.c | 22 ----------------------
test/test/virtual_pmd.c | 17 -----------------
7 files changed, 2 insertions(+), 88 deletions(-)
--
2.9.4
next prev parent reply other threads:[~2017-06-21 13:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 23:25 [dpdk-dev] [PATCH 0/5] eal: check socket memory Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 1/5] eal: check if socket has memory reserved Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 2/5] cryptodev: check if socket id has memory Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 3/5] crypto/scheduler: " Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 4/5] net/bonding: " Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 5/5] test/bonding: " Pablo de Lara
2017-06-21 5:07 ` Pablo de Lara [this message]
2017-06-21 5:07 ` [dpdk-dev] [PATCH v2 1/4] cryptodev: remove socket id check Pablo de Lara
2017-06-22 11:27 ` Declan Doherty
2017-06-21 5:07 ` [dpdk-dev] [PATCH v2 2/4] crypto/scheduler: " Pablo de Lara
2017-06-22 11:38 ` Declan Doherty
2017-06-21 5:07 ` [dpdk-dev] [PATCH v2 3/4] net/bonding: " Pablo de Lara
2017-06-22 11:47 ` Declan Doherty
2017-06-21 5:07 ` [dpdk-dev] [PATCH v2 4/4] test/bonding: " Pablo de Lara
2017-06-22 11:48 ` Declan Doherty
2017-06-22 15:47 ` [dpdk-dev] [PATCH v2 0/4] Socket ID check removal Thomas Monjalon
2017-06-21 11:33 ` [dpdk-dev] [PATCH 0/5] eal: check socket memory De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621050733.88850-1-pablo.de.lara.guarch@intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).