From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: declan.doherty@intel.com, fiona.trahe@intel.com
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH v2 1/9] crypto/aesni_mb: remove assert check
Date: Thu, 22 Jun 2017 13:02:27 +0100 [thread overview]
Message-ID: <20170622120235.46063-2-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <20170622120235.46063-1-pablo.de.lara.guarch@intel.com>
Some assert checks in the driver were
incorrect, but they are not necessary anyway,
as application will panic in any case.
Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue")
CC: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
index 45b25c9..43e4865 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
@@ -494,8 +494,6 @@ static inline void
verify_digest(JOB_AES_HMAC *job, struct rte_crypto_op *op) {
struct rte_mbuf *m_dst = (struct rte_mbuf *)job->user_data2;
- RTE_ASSERT(m_dst == NULL);
-
/* Verify digest if required */
if (memcmp(job->auth_tag_output, op->sym->auth.digest.data,
job->auth_tag_output_len_in_bytes) != 0)
@@ -522,8 +520,6 @@ post_process_mb_job(struct aesni_mb_qp *qp, JOB_AES_HMAC *job)
struct aesni_mb_session *sess;
- RTE_ASSERT(op == NULL);
-
if (unlikely(op->status == RTE_CRYPTO_OP_STATUS_ENQUEUED)) {
switch (job->status) {
case STS_COMPLETED:
--
2.9.4
next prev parent reply other threads:[~2017-06-22 20:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170621064154.25124-1-pablo.de.lara.guarch@intel.com>
2017-06-21 6:41 ` [dpdk-stable] [PATCH " Pablo de Lara
2017-06-21 6:41 ` [dpdk-stable] [PATCH 2/9] test/crypto: fix wrong AAD setting Pablo de Lara
2017-06-21 17:39 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
2017-06-22 10:40 ` De Lara Guarch, Pablo
2017-06-21 6:41 ` [dpdk-stable] [PATCH 6/9] examples/l2fwd-crypto: fix application help Pablo de Lara
2017-06-21 16:43 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
2017-06-21 6:41 ` [dpdk-stable] [PATCH 7/9] examples/l2fwd-crypto: fix auth info display Pablo de Lara
2017-06-21 16:44 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
2017-06-21 6:41 ` [dpdk-stable] [PATCH 8/9] app/crypto-perf: fix error message Pablo de Lara
2017-06-21 16:39 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
2017-06-21 6:41 ` [dpdk-stable] [PATCH 9/9] doc: fix typo in l2fwd-crypto usage Pablo de Lara
2017-06-21 17:44 ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona
[not found] ` <20170622120235.46063-1-pablo.de.lara.guarch@intel.com>
2017-06-22 12:02 ` Pablo de Lara [this message]
2017-06-23 12:50 ` [dpdk-stable] [PATCH v2 1/9] crypto/aesni_mb: remove assert check Declan Doherty
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 2/9] test/crypto: fix wrong AAD setting Pablo de Lara
2017-06-23 9:56 ` Trahe, Fiona
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 6/9] examples/l2fwd-crypto: fix application help Pablo de Lara
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 7/9] examples/l2fwd-crypto: fix auth info display Pablo de Lara
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 8/9] app/crypto-perf: fix error message Pablo de Lara
2017-06-22 12:02 ` [dpdk-stable] [PATCH v2 9/9] doc: fix typo in l2fwd-crypto usage Pablo de Lara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622120235.46063-2-pablo.de.lara.guarch@intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).