DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Martin Weiser <martin.weiser@allegro-packets.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Kumar Sanghvi <kumaras@chelsio.com>,
	Nirranjan Kirubaharan <nirranjan@chelsio.com>,
	Indranil Choudhury <indranil@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH v3] cxgbe: report 100G link speed capability for Chelsio T6 adapters
Date: Fri, 23 Jun 2017 11:06:26 +0530	[thread overview]
Message-ID: <20170623053625.GA30596@chelsio.com> (raw)
In-Reply-To: <1498126047-44989-1-git-send-email-martin.weiser@allegro-packets.com>

Hi Martin,

On Thursday, June 06/22/17, 2017 at 15:37:27 +0530, Martin Weiser wrote:
>    These adapters support 100G link speed but the speed_capa bitmask in the
>    device info did not reflect that.
> 
>    Signed-off-by: Martin Weiser <martin.weiser@allegro-packets.com>
>    ---
>     drivers/net/cxgbe/cxgbe_ethdev.c | 3 +++
>     1 file changed, 3 insertions(+)
> 
>    diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c
>    b/drivers/net/cxgbe/cxgbe_ethdev.c
>    index b622d25..1e56529 100644
>    --- a/drivers/net/cxgbe/cxgbe_ethdev.c
>    +++ b/drivers/net/cxgbe/cxgbe_ethdev.c
>    @@ -176,6 +176,9 @@ static void cxgbe_dev_info_get(struct rte_eth_dev
>    *eth_dev,
>             device_info->rx_desc_lim = cxgbe_desc_lim;
>             device_info->tx_desc_lim = cxgbe_desc_lim;
>             device_info->speed_capa = ETH_LINK_SPEED_10G |
>    ETH_LINK_SPEED_40G;
>    +
>    +       if (CHELSIO_CHIP_VERSION(adapter->params.chip) == CHELSIO_T6)
>    +               device_info->speed_capa |= ETH_LINK_SPEED_100G;
>     }
>     
>     static void cxgbe_dev_promiscuous_enable(struct rte_eth_dev *eth_dev)
>    --
>    2.7.4

Thanks for the patch.  However, not all Chelsio T6 adapters support
10G/40G/100G link speeds at the same time.  I have a patch to report
the supported link speeds correctly and is currently undergoing testing.
I will submit the patch very soon.

Thanks,
Rahul

      reply	other threads:[~2017-06-23  5:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 10:07 Martin Weiser
2017-06-23  5:36 ` Rahul Lakkireddy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170623053625.GA30596@chelsio.com \
    --to=rahul.lakkireddy@chelsio.com \
    --cc=dev@dpdk.org \
    --cc=indranil@chelsio.com \
    --cc=kumaras@chelsio.com \
    --cc=martin.weiser@allegro-packets.com \
    --cc=nirranjan@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).