From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Shachar Beiser <shacharbe@mellanox.com>,
dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault
Date: Mon, 26 Jun 2017 15:41:26 +0200 [thread overview]
Message-ID: <20170626134126.GF3093@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <7e3cc639-bcc5-b02b-0e89-8ddc98f82fcb@intel.com>
On Mon, Jun 26, 2017 at 01:55:33PM +0100, Ferruh Yigit wrote:
> On 6/26/2017 1:28 PM, Nélio Laranjeiro wrote:
> > On Sun, Jun 25, 2017 at 07:55:01AM +0000, Shachar Beiser wrote:
> >> Missing room in flow allocation to store the drop specification.
> >> Changing flow without storing the change in rte_flow.
> >> Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier")
> >>
> >> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
>
> > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>
> Hi Nelio, Shachar,
>
> What do you think squashing this and [1] into 88c77dedfbb0? Both this
> and [1] looks like fixing same commit.
>
> [1]
> e0e37c1f80a0 ("net/mlx5: fix creation of drop flows")
Hi Ferruh,
No it is not the same issue, one this new patch is fixing some code for
the hardware drop flow support which will be available with next version
of MLNX_OFED.
e0e37c1f80a0 ("net/mlx5: fix creation of drop flows") is fixing the
current version of the software drop queue which is possible with the
current MLNX_OFED GA.
Please keep them separate.
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-06-26 13:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 11:55 [dpdk-dev] [PATCH] " Shachar Beiser
2017-06-21 13:02 ` Nélio Laranjeiro
2017-06-22 9:51 ` Ferruh Yigit
2017-06-22 11:11 ` Ferruh Yigit
2017-06-25 7:42 ` [dpdk-dev] [PATCH v2] fix drop action seg fault missing compilation flag Shachar Beiser
2017-06-25 7:42 ` [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault Shachar Beiser
2017-06-25 7:46 ` Shachar Beiser
2017-06-25 7:46 ` [dpdk-dev] [PATCH v2] fix drop action seg fault missing compilation flag Shachar Beiser
2017-06-25 7:53 ` [dpdk-dev] [PATCH v2] Adding compilation flag for fix drop action seg fault Shachar Beiser
2017-06-25 7:55 ` Shachar Beiser
2017-06-25 7:53 ` [dpdk-dev] [PATCH v2] net/mlx5: " Shachar Beiser
2017-06-25 7:55 ` Shachar Beiser
2017-06-26 12:28 ` Nélio Laranjeiro
2017-06-26 12:55 ` Ferruh Yigit
2017-06-26 13:41 ` Nélio Laranjeiro [this message]
2017-06-26 13:51 ` Ferruh Yigit
2017-06-26 14:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626134126.GF3093@autoinstall.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shacharbe@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).