From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: ferruh.yigit@intel.com, dev@dpdk.org, adrien.mazarguil@6wind.com
Subject: Re: [dpdk-dev] [PATCH 2/5] net/mlx5: free buffers in bulk on Tx completion
Date: Fri, 30 Jun 2017 14:30:47 +0200 [thread overview]
Message-ID: <20170630123047.GO18305@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <20170628230403.10142-3-yskoh@mellanox.com>
On Wed, Jun 28, 2017 at 04:04:00PM -0700, Yongseok Koh wrote:
> When processing Tx completion, it is more efficient to free buffers in bulk
> using rte_mempool_put_bulk() if buffers are from a same mempool.
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 36 +++++++++++++++++++++++++++---------
> 1 file changed, 27 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 43db06ad8..d81d630f7 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -264,6 +264,8 @@ txq_complete(struct txq *txq)
> uint16_t cq_ci = txq->cq_ci;
> volatile struct mlx5_cqe *cqe = NULL;
> volatile struct mlx5_wqe_ctrl *ctrl;
> + struct rte_mbuf *m, *free[elts_n];
> + unsigned int blk_n = 0;
>
> do {
> volatile struct mlx5_cqe *tmp;
> @@ -296,21 +298,37 @@ txq_complete(struct txq *txq)
> assert((elts_tail & elts_m) < (1 << txq->wqe_n));
> /* Free buffers. */
> while (elts_free != elts_tail) {
> - struct rte_mbuf *elt = (*txq->elts)[elts_free & elts_m];
> - struct rte_mbuf *elt_next =
> - (*txq->elts)[(elts_free + 1) & elts_m];
> -
> + m = rte_pktmbuf_prefree_seg((*txq->elts)[elts_free++ & elts_m]);
> + if (likely(m != NULL)) {
> + if (blk_n) {
> + if (likely(m->pool == free[0]->pool)) {
> + free[blk_n++] = m;
> + } else {
> + rte_mempool_put_bulk(
> + free[0]->pool,
> + (void *)free,
> + blk_n);
The indentation is strange here, free[0] should be on the same line as
rte_mempool_put_bulk.
> + free[0] = m;
> + blk_n = 1;
> + }
> + } else {
> + free[0] = m;
> + blk_n = 1;
> + }
> + }
This loop could be smaller, blk_n can only be equal to 0 in the first
iteration, otherwise is >= 1.
The first if statement can be merged with the second one:
if (likely(m != NULL)) {
if (likely(blk_n && m->pool == free[0]->pool)) {
...
} else {
...
}
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-06-30 12:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 23:03 [dpdk-dev] [PATCH 0/5] net/mlx5: add vectorized Rx/Tx burst for x86 Yongseok Koh
2017-06-28 23:03 ` [dpdk-dev] [PATCH 1/5] net/mlx5: change indexing for Tx SW ring Yongseok Koh
2017-06-30 12:20 ` Nélio Laranjeiro
2017-06-28 23:04 ` [dpdk-dev] [PATCH 2/5] net/mlx5: free buffers in bulk on Tx completion Yongseok Koh
2017-06-30 12:30 ` Nélio Laranjeiro [this message]
2017-06-30 12:43 ` Nélio Laranjeiro
2017-06-30 17:49 ` Yongseok Koh
2017-06-28 23:04 ` [dpdk-dev] [PATCH 3/5] net/mlx5: use buffer address for LKEY search Yongseok Koh
2017-06-30 13:01 ` Nélio Laranjeiro
2017-06-30 18:58 ` Yongseok Koh
2017-06-28 23:04 ` [dpdk-dev] [PATCH 4/5] net/mlx5: select Rx/Tx callbacks when starting device Yongseok Koh
2017-06-30 13:02 ` Nélio Laranjeiro
2017-06-28 23:04 ` [dpdk-dev] [PATCH 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1 Yongseok Koh
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 0/5] net/mlx5: add vectorized Rx/Tx burst for x86 Yongseok Koh
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 1/5] net/mlx5: change indexing for Tx SW ring Yongseok Koh
2017-07-03 13:48 ` Nélio Laranjeiro
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 2/5] net/mlx5: free buffers in bulk on Tx completion Yongseok Koh
2017-07-03 13:58 ` Nélio Laranjeiro
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 3/5] net/mlx5: use buffer address for LKEY search Yongseok Koh
2017-07-03 14:06 ` Nélio Laranjeiro
2017-07-03 20:54 ` Yongseok Koh
2017-07-04 6:54 ` Nélio Laranjeiro
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: select Rx/Tx callbacks when starting device Yongseok Koh
2017-07-03 13:49 ` Nélio Laranjeiro
2017-06-30 19:23 ` [dpdk-dev] [PATCH v2 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1 Yongseok Koh
2017-07-03 23:54 ` Thomas Monjalon
2017-07-04 8:58 ` Nélio Laranjeiro
2017-07-05 0:38 ` Yongseok Koh
2017-07-05 8:21 ` Nélio Laranjeiro
2017-07-05 17:41 ` Yongseok Koh
2017-06-30 21:28 ` [dpdk-dev] [PATCH v2 0/5] net/mlx5: add vectorized Rx/Tx burst for x86 Bruce Richardson
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 " Yongseok Koh
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 1/5] net/mlx5: change indexing for Tx SW ring Yongseok Koh
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 2/5] net/mlx5: free buffers in bulk on Tx completion Yongseok Koh
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 3/5] net/mlx5: use buffer address for LKEY search Yongseok Koh
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 4/5] net/mlx5: select Rx/Tx callbacks when starting device Yongseok Koh
2017-07-06 7:17 ` Nélio Laranjeiro
2017-07-05 18:12 ` [dpdk-dev] [PATCH v3 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1 Yongseok Koh
2017-07-05 22:58 ` Yongseok Koh
2017-07-06 7:16 ` Nélio Laranjeiro
2017-07-06 9:58 ` Ferruh Yigit
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 0/5] net/mlx5: add vectorized Rx/Tx burst for x86 Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 1/5] net/mlx5: change indexing for Tx SW ring Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 2/5] net/mlx5: free buffers in bulk on Tx completion Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 3/5] net/mlx5: use buffer address for LKEY search Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 4/5] net/mlx5: select Rx/Tx callbacks when starting device Yongseok Koh
2017-07-06 18:41 ` [dpdk-dev] [PATCH v4 5/5] net/mlx5: add vectorized Rx/Tx burst for x86 Yongseok Koh
2017-07-07 9:58 ` [dpdk-dev] [PATCH v4 0/5] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630123047.GO18305@autoinstall.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).