From: Jens Freimann <jfreimann@redhat.com>
To: Yuanhan Liu <yliu@fridaylinux.org>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com
Subject: Re: [dpdk-dev] [PATCH 2/3] vhost: check return values of pthread_* calls
Date: Tue, 4 Jul 2017 11:28:41 +0200 [thread overview]
Message-ID: <20170704092841.vxsdzhugd463vct7@dhcp-192-218.str.redhat.com> (raw)
In-Reply-To: <20170704091728.GN11626@yliu-home>
On Tue, Jul 04, 2017 at 05:17:28PM +0800, Yuanhan Liu wrote:
>On Tue, Jul 04, 2017 at 10:50:42AM +0200, Jens Freimann wrote:
>> +out_mutex:
>> + if (pthread_mutex_destroy(&vsocket->conn_mutex))
>> + RTE_LOG(ERR, VHOST_CONFIG,
>> + "error: failed to destroy connection mutex\n");
>
>One minor comment though: {} should be used for one signle statement
>spawning more than one lines. See section "1.6.2. Control Statements
>and Loops":
>
> http://dpdk.org/doc/guides/contributing/coding_style.html
Sorry, checkpatch didn't complain. I'll make sure to add the
parentheses in the future.
>Anyway, I fixed while apply.
Thanks!
regards,
Jens
next prev parent reply other threads:[~2017-07-04 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 8:50 [dpdk-dev] [PATCH 0/3] vhost: small cleanups Jens Freimann
2017-07-04 8:50 ` [dpdk-dev] [PATCH 1/3] vhost: add missing check strdup() return value Jens Freimann
2017-07-04 8:50 ` [dpdk-dev] [PATCH 2/3] vhost: check return values of pthread_* calls Jens Freimann
2017-07-04 9:17 ` Yuanhan Liu
2017-07-04 9:28 ` Jens Freimann [this message]
2017-07-04 8:50 ` [dpdk-dev] [PATCH 3/3] vhost: check return value of pthread_mutex_init() Jens Freimann
2017-07-04 9:15 ` [dpdk-dev] [PATCH 0/3] vhost: small cleanups Yuanhan Liu
2017-07-04 9:23 ` Jens Freimann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704092841.vxsdzhugd463vct7@dhcp-192-218.str.redhat.com \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).