From: Yuanhan Liu <yliu@fridaylinux.org>
To: Changpeng Liu <changpeng.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: introduce a new vhost-user-scsi sample application
Date: Fri, 7 Jul 2017 12:48:54 +0800 [thread overview]
Message-ID: <20170707044854.GV11626@yliu-home> (raw)
In-Reply-To: <1499487291-17053-1-git-send-email-changpeng.liu@intel.com>
On Sat, Jul 08, 2017 at 12:14:51PM +0800, Changpeng Liu wrote:
> +.. note::
> + You must check whether your Qemu can support "vhost-user-scsi" or not,
> + Qemu v2.9.50 or newer version is required.
QEMU v2.9.50 looks like a stable version, and I don't think they will
backport new features on it (or, do they?).
So, it should be "v2.10" here?
> + switch (pc) {
> + case SPC_VPD_SUPPORTED_VPD_PAGES:
> + hlen = 4;
> + vpage->params[0] = SPC_VPD_SUPPORTED_VPD_PAGES;
> + vpage->params[1] = SPC_VPD_UNIT_SERIAL_NUMBER;
> + vpage->params[2] = SPC_VPD_DEVICE_IDENTIFICATION;
> + len = 3;
> + /* PAGE LENGTH */
> + to_be16(vpage->alloc_len, len);
> + break;
You didn't resolve my previous comment regarding the "break"
indentation issue.
Otherwise, this patch looks good to me.
--yliu
next prev parent reply other threads:[~2017-07-07 4:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 9:28 [dpdk-dev] [PATCH] " Changpeng Liu
2017-07-07 0:50 ` Yuanhan Liu
2017-07-07 2:00 ` Liu, Changpeng
2017-07-07 2:09 ` Yuanhan Liu
2017-07-08 4:14 ` [dpdk-dev] [PATCH v2] " Changpeng Liu
2017-07-07 4:48 ` Yuanhan Liu [this message]
2017-07-07 4:54 ` Liu, Changpeng
2017-07-08 5:21 ` [dpdk-dev] [PATCH v3] " Changpeng Liu
2017-07-07 5:07 ` Yuanhan Liu
2017-07-07 8:40 ` Hemant Agrawal
2017-07-07 9:44 ` Yuanhan Liu
2017-07-07 12:21 ` Thomas Monjalon
2017-07-08 2:53 ` Yuanhan Liu
2017-07-09 16:42 ` Thomas Monjalon
2017-07-12 14:49 ` Wodkowski, PawelX
2017-07-15 8:20 ` [dpdk-dev] [PATCH v4] " Changpeng Liu
2017-07-18 14:24 ` Thomas Monjalon
2017-07-19 0:20 ` Liu, Changpeng
2017-07-19 4:18 ` Thomas Monjalon
2017-07-19 4:24 ` Liu, Changpeng
2017-07-20 9:16 ` [dpdk-dev] [PATCH v5] " Changpeng Liu
2017-07-19 19:48 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707044854.GV11626@yliu-home \
--to=yliu@fridaylinux.org \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).