From: Yuanhan Liu <yliu@fridaylinux.org>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: Changpeng Liu <changpeng.liu@intel.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3] examples/vhost: introduce a new vhost-user-scsi sample application
Date: Fri, 7 Jul 2017 17:44:19 +0800 [thread overview]
Message-ID: <20170707094419.GY11626@yliu-home> (raw)
In-Reply-To: <0d8dbc6e-c6b3-4c75-18e7-5874f640f517@nxp.com>
On Fri, Jul 07, 2017 at 02:10:57PM +0530, Hemant Agrawal wrote:
> On 7/7/2017 10:37 AM, Yuanhan Liu wrote:
> >On Sat, Jul 08, 2017 at 01:21:37PM +0800, Changpeng Liu wrote:
> >>vhost-user protocol is common to many virtio devices, such as
> >>virtio_net/virtio_scsi/virtio_blk. Since DPDK vhost library
> >>removed the NET specific data structures, the vhost library
> >>is common to other virtio devices, such as virtio-scsi.
> >>
> >>Here we introduce a simple memory based block device that
> >>can be presented to Guest VM through vhost-user-scsi-pci
> >>controller. Similar with vhost-net, the sample application
> >>will process the I/Os sent via virt rings.
> >>
> >>Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
> >
> >Applied to dpdk-next-virtio.
> >
>
> Though my comment is late.
> I am just wondering if it is not better to refactor the existing vhost
> applications and add this as a mode instead of adding one more sample
> application?
Ideally, yes. However, I don't find a straightforward way to do that
for this scsi example, for following reasons:
- Current vhost switch example was not well designed. Worse, it has
has few NIC features bond, say VMDq and VLAN.
- Vhost switch is for networking, while this one is for storage. To
let them co-exist in one app, we have to firstly refactor current
vhost-user example, which should be a big rework that I don't think
it's worthwhile.
Or, maybe we could put vhost_switch and vhost_scsi into one dir (say
"vhost") under examples and let them look like one example (with 2
standalone apps), like what we did for multi_process examples?
And we probably could do more, for example, the l2fwd, l3fwd and
their variants?
However, IMO, it just make the examples dir more cleanly, nothing
else. Except someone will spend more time to refactor them, such as
removing the duplicate code and introduce them as helper functions.
Again, It may not be that worthwhile, judging that they are just
examples.
--yliu
next prev parent reply other threads:[~2017-07-07 9:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 9:28 [dpdk-dev] [PATCH] " Changpeng Liu
2017-07-07 0:50 ` Yuanhan Liu
2017-07-07 2:00 ` Liu, Changpeng
2017-07-07 2:09 ` Yuanhan Liu
2017-07-08 4:14 ` [dpdk-dev] [PATCH v2] " Changpeng Liu
2017-07-07 4:48 ` Yuanhan Liu
2017-07-07 4:54 ` Liu, Changpeng
2017-07-08 5:21 ` [dpdk-dev] [PATCH v3] " Changpeng Liu
2017-07-07 5:07 ` Yuanhan Liu
2017-07-07 8:40 ` Hemant Agrawal
2017-07-07 9:44 ` Yuanhan Liu [this message]
2017-07-07 12:21 ` Thomas Monjalon
2017-07-08 2:53 ` Yuanhan Liu
2017-07-09 16:42 ` Thomas Monjalon
2017-07-12 14:49 ` Wodkowski, PawelX
2017-07-15 8:20 ` [dpdk-dev] [PATCH v4] " Changpeng Liu
2017-07-18 14:24 ` Thomas Monjalon
2017-07-19 0:20 ` Liu, Changpeng
2017-07-19 4:18 ` Thomas Monjalon
2017-07-19 4:24 ` Liu, Changpeng
2017-07-20 9:16 ` [dpdk-dev] [PATCH v5] " Changpeng Liu
2017-07-19 19:48 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707094419.GY11626@yliu-home \
--to=yliu@fridaylinux.org \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).