From: Stephen Hemminger <stephen@networkplumber.org>
To: yliu@fridaylinux.org, maxime.coquelin@redhat.com
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims
Date: Fri, 7 Jul 2017 12:52:48 -0700 [thread overview]
Message-ID: <20170707195250.22259-1-stephen@networkplumber.org> (raw)
While doing code for Hyper-V, noticed that the virtio driver was
confused about receive versus transmit offloads. The virtio
checksum offload is L4 (TCP/UDP) only, not IPv4. Also, TSO
and LRO are not the same.
This may break some program that was assuming it was getting offloads
that it wasn't.
Stephen Hemminger (2):
virtio: don't falsely claim to do IP checksum
virtio: don't claim to support LRO
drivers/net/virtio/virtio_ethdev.c | 30 +++++-------------------------
1 file changed, 5 insertions(+), 25 deletions(-)
--
2.11.0
next reply other threads:[~2017-07-07 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 19:52 Stephen Hemminger [this message]
2017-07-07 19:52 ` [dpdk-dev] [PATCH 1/2] virtio: don't falsely claim to do IP checksum Stephen Hemminger
2017-07-07 19:52 ` [dpdk-dev] [PATCH 2/2] virtio: don't claim to support LRO Stephen Hemminger
2017-07-08 3:12 ` [dpdk-dev] [PATCH 0/2] virtio fix false offload claims Yuanhan Liu
2017-08-23 9:30 ` Olivier MATZ
2017-08-23 15:31 ` Stephen Hemminger
2017-08-23 16:14 ` Olivier MATZ
2017-08-23 16:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707195250.22259-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).