From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
dev@dpdk.org, jerin.jacob@caviumnetworks.com,
hemant.agrawal@nxp.com, jasvinder.singh@intel.com,
wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1
Date: Mon, 10 Jul 2017 09:43:17 +0200 [thread overview]
Message-ID: <20170710074317.GR19852@6wind.com> (raw)
In-Reply-To: <1838852.sCttUoyffy@xps>
Hi Thomas,
On Sun, Jul 09, 2017 at 10:01:31PM +0200, Thomas Monjalon wrote:
> Hi,
>
> 04/07/2017 17:38, Cristian Dumitrescu:
> > http://dpdk.org/git/next/dpdk-next-tm
>
> I'm sorry to not have considered this tree as a high priority.
> I think it may be integrated in RC2 because it is a totally new area
> and should not break any existing code.
>
> I prefer to wait because I have seen some things to fix:
>
> 1/ There is a compilation error with clang (notified in related thread).
>
> 2/ Some functions are exposed in the API to query the ops.
> It seems dangerous and useless:
> - rte_eth_dev_tm_ops_get
> - rte_tm_ops_get
>
> 3/ The PMD interface file is referenced in the doxygen index:
> + [rte_tm_driver] (@ref rte_tm_driver.h),
> I see that rte_flow_driver.h is also referenced but it seems a mistake.
Why? It was done on purpose, I think exposing through Doxygen internal APIs
implemented by drivers must be a requirement, even if the exposed symbols
are not necessarily versioned.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-07-10 7:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 15:38 Cristian Dumitrescu
2017-07-04 15:47 ` Thomas Monjalon
2017-07-04 16:52 ` Dumitrescu, Cristian
2017-07-04 20:21 ` Thomas Monjalon
2017-07-05 10:36 ` Dumitrescu, Cristian
2017-07-09 20:01 ` Thomas Monjalon
2017-07-10 7:43 ` Adrien Mazarguil [this message]
2017-07-10 7:51 ` Thomas Monjalon
2017-07-10 10:55 ` Dumitrescu, Cristian
2017-07-10 12:57 ` Thomas Monjalon
2017-07-10 13:21 ` Dumitrescu, Cristian
2017-07-10 13:49 ` Thomas Monjalon
2017-07-10 15:46 ` Dumitrescu, Cristian
2017-07-10 15:54 ` Thomas Monjalon
2017-07-10 16:47 ` Dumitrescu, Cristian
2017-07-10 16:58 ` Thomas Monjalon
2017-07-11 18:20 ` Dumitrescu, Cristian
2017-07-12 17:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710074317.GR19852@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jasvinder.singh@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).