DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Herbert Guan <herbert.guan@arm.com>
Cc: dev@dpdk.org, jianbo.liu@linaro.org
Subject: Re: [dpdk-dev] [PATCH] ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.
Date: Wed, 12 Jul 2017 23:15:15 +0530	[thread overview]
Message-ID: <20170712174514.GA13824@jerin> (raw)
In-Reply-To: <1499856619-21007-1-git-send-email-herbert.guan@arm.com>

-----Original Message-----
> Date: Wed, 12 Jul 2017 18:50:19 +0800
> From: Herbert Guan <herbert.guan@arm.com>
> To: dev@dpdk.org, jerin.jacob@caviumnetworks.com, jianbo.liu@linaro.org
> CC: Herbert Guan <herbert.guan@arm.com>
> Subject: [PATCH] ARMv8: Use built-in data types for unsupported poly64/128
>  types for GCC version lower than 4.9.0.
> X-Mailer: git-send-email 1.8.3.1
> 
> Fixes: 3c4b4024c2 (arch/arm: add vcopyq_laneq_u32 for old gcc)

Fix the check-git-log.sh warning. You could start the commit with
eal/armv8:

With check-git-log.sh fix:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

[master][dpdk.org] $ ./devtools/check-git-log.sh 
Wrong headline format:
	ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.
Wrong headline uppercase:
	ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.
Headline too long:
	ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.



> 
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
>  lib/librte_eal/common/include/arch/arm/rte_vect.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_vect.h b/lib/librte_eal/common/include/arch/arm/rte_vect.h
> index 7fec25e..782350d 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_vect.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_vect.h
> @@ -101,6 +101,13 @@
>  
>  #if defined(RTE_ARCH_ARM64)
>  #if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70000)
> +
> +#if (GCC_VERSION < 40900)
> +typedef uint64_t poly64_t;
> +typedef uint64x2_t poly64x2_t;
> +typedef uint8_t poly128_t __attribute__((vector_size(16), aligned(16)));
> +#endif
> +
>  /* NEON intrinsic vreinterpretq_u64_p128() is supported since GCC version 7 */
>  static inline uint64x2_t
>  vreinterpretq_u64_p128(poly128_t x)
> -- 
> 1.8.3.1
> 

  parent reply	other threads:[~2017-07-12 17:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12 10:50 Herbert Guan
2017-07-12 15:36 ` Jianbo Liu
2017-07-12 17:45 ` Jerin Jacob [this message]
2017-07-13  3:13   ` Herbert Guan
2017-07-13  2:16 ` [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0) Herbert Guan
2017-07-18 14:44   ` Thomas Monjalon
2017-07-19  8:21     ` Herbert Guan
2017-07-19 12:31       ` Thomas Monjalon
2017-07-24 10:25         ` Herbert Guan
2017-07-31  7:24   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712174514.GA13824@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=herbert.guan@arm.com \
    --cc=jianbo.liu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).