From: Olivier Matz <olivier.matz@6wind.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, thomas.monjalon@6wind.com, jerin.jacob@caviumnetworks.com
Subject: Re: [dpdk-dev] [PATCH] mempool: add notice to change mempool API/ABI
Date: Thu, 20 Jul 2017 10:46:19 +0200 [thread overview]
Message-ID: <20170720104619.06a5921f@platinum> (raw)
In-Reply-To: <20170713091231.13314-1-santosh.shukla@caviumnetworks.com>
On Thu, 13 Jul 2017 09:12:31 +0000, Santosh Shukla <santosh.shukla@caviumnetworks.com> wrote:
> [PATCH] mempool: add notice to change mempool API/ABI
I think the usual titles for these notices are more:
doc: announce API/ABI changes for mempool
Ideally, the title should describe more precisely the kind of
changes. In that particular case, it looks quite difficult,
so just saying "mempool" looks okay. Maybe Thomas will prefer
one entry per change, I don't know.
> An API/ABI change is planned for 17.11 to change following
>
> * Remove unused flag param from rte_mempool_generic_get and _put.
> * Change data type for mempool 'flag' from int to unsigned int.
> Refer [1].
> * Add struct rte_mempool * param into func rte_mempool_xmem_size,
> rte_mempool_xmem_usage to make it mempool aware.
> Refer [2].
>
> [1] http://dpdk.org/dev/patchwork/patch/25603/
> [2] http://dpdk.org/dev/patchwork/patch/25605/
>
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 257dcba32..7abb30f5f 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -64,3 +64,11 @@ Deprecation Notices
> be removed in 17.11:
>
> - ``rte_eal_parse_devargs_str``, replaced by ``rte_eal_devargs_parse``
> +
> +* mempool: The following will be modified in 17.11:
I think an empty line is required here, else the generated pdf will
be incorrect.
> + - ``rte_mempool_xmem_size`` and ``rte_mempool_xmem_usage`` need to know
> + the mempool flag status so adding new param rte_mempool in those API.
> + - Removing __rte_unused int flag param from ``rte_mempool_generic_put``
> + and ``rte_mempool_generic_get`` API.
> + - ``rte_mempool`` flags data type will changed from int to
> + unsigned int.
next prev parent reply other threads:[~2017-07-20 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 9:12 Santosh Shukla
2017-07-20 8:46 ` Olivier Matz [this message]
2017-07-20 9:27 ` santosh
2017-07-20 11:26 ` Thomas Monjalon
2017-07-20 10:29 ` [dpdk-dev] [PATCH v2] doc: announce API/ABI changes for mempool Santosh Shukla
2017-07-21 6:26 ` santosh
2017-08-03 14:21 ` Jerin Jacob
2017-08-03 14:30 ` santosh
2017-08-05 20:24 ` Olivier MATZ
2017-08-08 0:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720104619.06a5921f@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).