From: Yuanhan Liu <yliu@fridaylinux.org>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, zhihong.wang@intel.com, john.mcnamara@intel.com,
oilvier.matz@6wind.com, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] doc: announce API and ABI change for ethdev
Date: Fri, 4 Aug 2017 12:07:28 +0800 [thread overview]
Message-ID: <20170804040728.GE9612@yliu-home> (raw)
In-Reply-To: <20170712075846.14834-1-zhiyong.yang@intel.com>
On Wed, Jul 12, 2017 at 03:58:46PM +0800, Zhiyong Yang wrote:
> This is an API/ABI change notice for DPDK 17.11 on redefinition of
Don't put 2 whitespace char indentation here.
> port_id. port_id is defined as uint8_t by now, which is just ranged
> from 0 to 255. For more and more scenerioes, more than 256 devices are
> needed to support for vdev scalability.
>
> It is necessary for redefinition of port_id to extend from 1 bytes
> to 2 bytes. All ethdev APIs and use cases related to port_id will be
> changed at the same time.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 257dcba..f265980 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -54,6 +54,10 @@ Deprecation Notices
> Target release for removal of the legacy API will be defined once most
> PMDs have switched to rte_flow.
>
> +* ABI/API changes are planned for 17.11 in the "rte_eth_dev_data" structure.
That's for ABI only and you missed the API part. Meaning, you need also
mention that all APIs have port_id parameter will be changed too.
Also, rte_eth_dev_data is not the only structure has ABI changes. There
are few more (for instance, rte_port_ethdev.h). As said before, you don't
have to list all of them, but at least you should not list one example
only as it seems that's the only structure has ABI change.
> + Change the definition of port_id from 8bits to 16bits in order to support
> + more than 256 devices in DPDK.
8bits -> 8 bits. You might want to reword it further. Besides that, this
change is indeed needed. Thus,
Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
--yliu
> +
> * librte_table: The ``key_mask`` parameter will be added to all the hash tables
> that currently do not have it, as well as to the hash compute function prototype.
> The non-"do-sig" versions of the hash tables will be removed
> --
> 2.9.3
next prev parent reply other threads:[~2017-08-04 4:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 7:58 Zhiyong Yang
2017-08-04 1:12 ` Tan, Jianfeng
2017-08-04 4:07 ` Yuanhan Liu [this message]
2017-08-04 4:13 ` Jerin Jacob
2017-08-04 5:36 ` Yang, Zhiyong
2017-08-04 5:27 ` [dpdk-dev] [PATCH v2] " Zhiyong Yang
2017-08-04 6:56 ` Remy Horton
2017-08-05 10:34 ` Yang, Zhiyong
2017-08-07 3:07 ` Yang, Zhiyong
2017-08-07 11:04 ` Thomas Monjalon
2017-08-07 15:20 ` Shahaf Shuler
2017-08-07 12:42 ` [dpdk-dev] [PATCH v3] " Zhiyong Yang
2017-08-08 4:02 ` Yang, Zhiyong
2017-08-08 9:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804040728.GE9612@yliu-home \
--to=yliu@fridaylinux.org \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=oilvier.matz@6wind.com \
--cc=thomas@monjalon.net \
--cc=zhihong.wang@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).