From: Neil Horman <nhorman@tuxdriver.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] atm: Remove machine definition
Date: Thu, 10 Aug 2017 07:33:57 -0400 [thread overview]
Message-ID: <20170810113356.GA14414@hmswarspite.think-freely.org> (raw)
In-Reply-To: <20170810083418.GA53940@bricha3-MOBL3.ger.corp.intel.com>
On Thu, Aug 10, 2017 at 09:34:18AM +0100, Bruce Richardson wrote:
> On Wed, Aug 09, 2017 at 04:24:25PM -0400, Neil Horman wrote:
> > With the new updated requirement for SSE4.2, dpdk no longer supports
> > building on atom machines, as they only support up to SSE3. Remove
> > the machine definition.
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com> CC: Thomas Monjalon
> > <thomas@monjalon.net> --- mk/machine/atm/rte.vars.mk | 58
> > ---------------------------------------------- 1 file changed, 58
> > deletions(-) delete mode 100644 mk/machine/atm/rte.vars.mk
> >
> Yes, good catch, that should have been removed. However, I think the
> commit log should be updated to mention that it no longer supports
> "early" atom machines, or some similar phrase. Atom cores for the last
> number of years do support SSE4, see:
> https://en.wikipedia.org/wiki/Silvermont for example.
>
I don't really agree with that. If you want to make the claim that only early
atom machines aren't supported, the implication then is that later atom machines
are, and we should keep the machine type, and fix it to build for those targeted
machines (as it stands currently, the compiler errors out on building atom
because it only emits SSE3 instructions and can't inline an SSE4 builtin). I'd
be totally fine with fixing the atom build (which I imageine amounts to passing
-machine=atom -msse4 or something simmilar to the build options. Once we do
that however, we likely need a runtime check for sse4 support as well, so we
don't just get random SIGILL errors at run time.
Neil
> With that change,
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
>
next prev parent reply other threads:[~2017-08-10 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 20:24 Neil Horman
2017-08-10 8:34 ` Bruce Richardson
2017-08-10 11:33 ` Neil Horman [this message]
2017-08-10 14:04 ` Richardson, Bruce
2017-08-10 15:15 ` Neil Horman
2017-08-10 15:40 ` Bruce Richardson
2017-08-11 11:04 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810113356.GA14414@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).