From: Bruce Richardson <bruce.richardson@intel.com>
To: Medvedkin Vladimir <medvedkinv@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC] Add RIB library
Date: Mon, 14 Aug 2017 11:51:56 +0100 [thread overview]
Message-ID: <20170814105156.GA8112@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1499801585-10031-1-git-send-email-medvedkinv@gmail.com>
On Tue, Jul 11, 2017 at 07:33:04PM +0000, Medvedkin Vladimir wrote:
> Hi,
>
> I want to introduce new library for ip routing lookup that have some advantages
> over current LPM library. In short:
> - Increases the speed of control plane operations against lpm such as
> adding/deleting routes
> - Adds abstraction from dataplane algorythms, so it is possible to add
> different ip route lookup algorythms such as DXR/poptrie/lpc-trie/etc
> in addition to current dir24_8
> - It is possible to keep user defined application specific additional
> information in struct rte_rib_v4_node which represents route entry.
> It can be next hop/set of next hops (i.e. active and feasible),
> pointers to link rte_rib_v4_node based on some criteria (i.e. next_hop),
> plenty of additional control plane information.
> - For dir24_8 implementation it is possible to remove rte_lpm_tbl_entry.depth
> field that helps to save 6 bits.
> - Also new dir24_8 implementation supports different next_hop sizes
> (1/2/4/8 bytes per next hop)
>
> It would be nice to hear your opinion. The draft is below.
>
> Medvedkin Vladimir (1):
> lib/rib: Add Routing Information Base library
>
On reading this patch and then having discussion with you offline, it
appears there are two major new elements in this patchset:
1. a re-implementation of LPM, with the major advantage of having a
flexible data-size
2. a separate control plane structure that is designed to fit on top off
possibly multiple lookup structures for the data plane
Is this correct?
For the first part, I don't think we should carry about two separate LPM
implementations, but rather look to take the improvements in your
version back into the existing lib. [Or else replace the existing one,
but I prefer pulling the new stuff into it, so as to keep backward
compatibility]
For the second part, perhaps you could expand a bit more on the thought
here, and explain what all different data plane implementations would
fit under it. Would, for instance a hash-lookup work? In that case, what
would the data plane APIs be, and the control plane ones.
Thanks,
/Bruce
next prev parent reply other threads:[~2017-08-14 10:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 19:33 Medvedkin Vladimir
2017-07-11 19:33 ` [dpdk-dev] [PATCH] lib/rib: Add Routing Information Base library Medvedkin Vladimir
2017-07-11 20:28 ` Stephen Hemminger
2017-07-11 23:17 ` Vladimir Medvedkin
2017-07-11 20:31 ` [dpdk-dev] [RFC] Add RIB library Stephen Hemminger
2017-07-11 23:13 ` Vladimir Medvedkin
2017-08-14 10:51 ` Bruce Richardson [this message]
2017-08-14 22:28 ` Vladimir Medvedkin
2017-08-15 8:23 ` Bruce Richardson
2017-08-15 10:49 ` Vladimir Medvedkin
2017-08-15 11:01 ` Vladimir Medvedkin
2018-01-16 0:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814105156.GA8112@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=medvedkinv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).