patches for DPDK stable branches
 help / color / mirror / Atom feed

From: Olivier MATZ <olivier.matz@6wind.com>
To: Yuanhan Liu <yliu@fridaylinux.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	maxime.coquelin@redhat.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 0/2] virtio fix false offload claims
Date: Wed, 23 Aug 2017 11:30:26 +0200	[thread overview]
Message-ID: <20170823093025.bhjwbygfyz4ifd6r@glumotte.dev.6wind.com> (raw)
In-Reply-To: <20170708031222.GA11626@yliu-home>

Hello,

On Sat, Jul 08, 2017 at 11:12:22AM +0800, Yuanhan Liu wrote:
> On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote:
> > While doing code for Hyper-V, noticed that the virtio driver was
> > confused about receive versus transmit offloads.  The virtio
> > checksum offload is L4 (TCP/UDP) only, not IPv4. Also, TSO
> > and LRO are not the same.
> > 
> > This may break some program that was assuming it was getting offloads
> > that it wasn't.
> 
> Applied to dpdk-next-virtio.
> 
> And I think they should be backported to stable releases, thus,
> 
>     Cc: stable@dpdk.org
> 
> Thanks.
> 
> 	--yliu
> > 
> > Stephen Hemminger (2):
> >   virtio: don't falsely claim to do IP checksum
> >   virtio: don't claim to support LRO
> > 
> >  drivers/net/virtio/virtio_ethdev.c | 30 +++++-------------------------
> >  1 file changed, 5 insertions(+), 25 deletions(-)
> > 
> > -- 
> > 2.11.0

I think these 2 commits break the virtio offload, which can be tested as
described in this test plan:
http://dpdk.org/ml/archives/dev/2016-October/048092.html

First, about checksum: the description of rxmode->hw_ip_checksum is:

     hw_ip_checksum   : 1, /**< IP/UDP/TCP checksum offload enable. */

So, while I agree the name is not well chosen, it is valid to set it
for virtio to enable L4 checksum.

Then about LRO: setting rxmode->enable_lro is a way to tell the host that the
guest is ok to receive tso packets. From the guest point of view, it is like
enabling lro on a physical driver. Again, it is valid and useful to do this.

Before removing these features, it would have been nice to have a quick look at
the commits that introduced them.

Olivier

next prev parent reply	other threads:[~2017-08-23  9:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170707195250.22259-1-stephen@networkplumber.org>
2017-07-08  3:12 ` [dpdk-stable] " Yuanhan Liu
2017-08-23  9:30   ` Olivier MATZ [this message]
2017-08-23 15:31     ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2017-08-23 16:14       ` Olivier MATZ
2017-08-23 16:41         ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823093025.bhjwbygfyz4ifd6r@glumotte.dev.6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).