From: Bruce Richardson <bruce.richardson@intel.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/2] eal/x86: implement x86 specific tsc hz
Date: Wed, 23 Aug 2017 15:03:46 +0100 [thread overview]
Message-ID: <20170823140346.GA6672@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <3221201e-2e7f-f366-2b7b-cc60f140d01b@intel.com>
On Wed, Aug 23, 2017 at 02:57:30PM +0100, Sergio Gonzalez Monroy wrote:
> On 23/08/2017 14:17, Bruce Richardson wrote:
> > On Wed, Aug 23, 2017 at 01:42:41PM +0100, Sergio Gonzalez Monroy wrote:
> > > First, try to use CPUID Time Stamp Counter and Nominal Core Crystal
> > > Clock Information Leaf to determine the tsc hz on platforms that
> > > supports it (does not require priviledge user).
> > >
> > > If the CPUID leaf is not available, then try to determine the tsc hz by
> > > reading the MSR 0xCE (requires priviledge user).
> > >
> > > Default to the DPDK tsc hz estimation if both methods fail.
> > >
> > > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> > > ---
> > This patch depends on Jerin's previous set for getting the exact TSC
> > frequency on different platforms, right?
>
> It does, I forgot to mention it.
>
> I'll send them apart as these patches are not really dependent.
>
Ok, the patches look good to me otherwise, so include my ack if
re-sending.
Series-Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2017-08-23 14:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 12:42 [dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin Sergio Gonzalez Monroy
2017-08-23 12:42 ` [dpdk-dev] [PATCH 2/2] eal/x86: implement x86 specific tsc hz Sergio Gonzalez Monroy
2017-08-23 13:17 ` Bruce Richardson
2017-08-23 13:57 ` Sergio Gonzalez Monroy
2017-08-23 14:03 ` Bruce Richardson [this message]
2017-08-23 20:49 ` [dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin Thomas Monjalon
2017-08-24 8:21 ` Sergio Gonzalez Monroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823140346.GA6672@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).