From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Raslan Darawsheh <rasland@mellanox.com>,
jingjing.wu@intel.com, dev@dpdk.org, salehals@mellanox.com
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command
Date: Fri, 25 Aug 2017 09:53:31 +0200 [thread overview]
Message-ID: <20170825075331.GB8124@bidouze.vm.6wind.com> (raw)
In-Reply-To: <2302304.eNG2ySBljJ@xps>
On Wed, Aug 23, 2017 at 06:18:34PM +0200, Thomas Monjalon wrote:
> 23/08/2017 17:09, Gaëtan Rivet:
> > Hello Raslan,
> >
> > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote:
> > > Added hotplug in testpmd, to be able to test hotplug function
> > > in the PMD's.
> > >
> > > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> [...]
> > > --- a/app/test-pmd/cmdline.c
> > > +++ b/app/test-pmd/cmdline.c
> > > @@ -716,6 +716,9 @@ static void cmd_help_long_parsed(void *parsed_result,
> > > "port config (port_id|all) l2-tunnel E-tag"
> > > " (enable|disable)\n"
> > > " Enable/disable the E-tag support.\n\n"
> > > +
> > > + " device remove (device)\n"
> > > + " Remove a device"
> >
> > I think it should still be a part of the "port" command set (port
> > attach|detach|stop|close, etc).
>
> I tend to disagree.
> As far as I know, we use port for ethdev or cryptodev.
> Here we want to deal with EAL rte_device.
>
I see, that makes sense.
I will redo the review with that in mind.
> > This would probably be easier to understand for users.
>
> [...]
> > Continuing on using the port ...
> > format, then the port_id should allow to remove it instead of the device
> > identifier.
> > Using the device identifier will complexify your implementation.
> [...]
> > eth_dev = &rte_eth_devices[port_id];
> > bus = rte_bus_find_by_device(eth_dev->device);
>
> Note that we are going to remove eth_dev->device which implies eth_dev
> but maybe also more device interfaces for the same HW.
> That's why I think we need to distinguish port and device somehow.
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2017-08-25 7:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 14:37 Raslan Darawsheh
2017-08-23 15:09 ` Gaëtan Rivet
2017-08-23 16:18 ` Thomas Monjalon
2017-08-25 7:53 ` Gaëtan Rivet [this message]
2017-08-25 8:55 ` Thomas Monjalon
2017-08-28 9:55 ` Gaëtan Rivet
2017-08-28 10:30 ` Ferruh Yigit
2017-08-28 11:00 ` Thomas Monjalon
2017-08-28 11:12 ` Gaëtan Rivet
2017-09-07 8:17 ` Wu, Jingjing
2017-11-28 22:02 ` Ferruh Yigit
2017-12-03 9:32 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825075331.GB8124@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=rasland@mellanox.com \
--cc=salehals@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).