From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Raslan Darawsheh <rasland@mellanox.com>,
thomas@monjalon.net, jingjing.wu@intel.com, dev@dpdk.org,
salehals@mellanox.com
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command
Date: Mon, 28 Aug 2017 13:12:40 +0200 [thread overview]
Message-ID: <20170828111240.GF8124@bidouze.vm.6wind.com> (raw)
In-Reply-To: <2200a72f-92bb-c4e6-db9d-b00961fc328b@intel.com>
On Mon, Aug 28, 2017 at 11:30:47AM +0100, Ferruh Yigit wrote:
> On 8/28/2017 10:55 AM, Gaëtan Rivet wrote:
> > Hi Raslan,
> >
> > Redoing the review with the remarks from Thomas in mind.
> >
> > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote:
> >> Added hotplug in testpmd, to be able to test hotplug function
> >> in the PMD's.
> >>
> >> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> >> ---
> >> app/test-pmd/cmdline.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> >> app/test-pmd/testpmd.c | 18 ++++++++++++++++++
> >> app/test-pmd/testpmd.h | 1 +
> >> 3 files changed, 63 insertions(+)
> >>
> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> >> index cd8c358..b32a368 100644
> >> --- a/app/test-pmd/cmdline.c
> >> +++ b/app/test-pmd/cmdline.c
> >> @@ -716,6 +716,9 @@ static void cmd_help_long_parsed(void *parsed_result,
> >> "port config (port_id|all) l2-tunnel E-tag"
> >> " (enable|disable)\n"
> >> " Enable/disable the E-tag support.\n\n"
> >> +
> >> + " device remove (device)\n"
> >
> > I think (device) might be hard to understand for a user.
> > Maybe (device name)?
>
> I am suspicious on adding new root level command to testpmd, it is
> getting bigger, each command looks OK on its own context, but as a whole
> app getting more confusing [1].
>
> Since dealing with device is kind of new, it can be OK to create new
> command tree, but there are already hotplug commands per port:
> "port attach #PCI|#VDEV_NAME"
> "port detach #P"
>
Those two commands deal with the etherdev hotplug API.
The new command should test the rte_dev one.
As Thomas pointed out, the etherdev one deals only with eth ports, while
hotplug could be generalized to other devices, such as cryptodev.
> perhaps it can be good to keep "attach", "detach" keywords for device to
> be consistent?
>
> "device attach #name"
> "device detach #name"
>
I made a point of naming the hotplug operations in rte_bus plug/unplug
to avoid the confusion with the etherdev API. hotplug_add /
hotplug_remove also marks the distinction.
I don't know if it would be helpful for a developer writing a PMD,
searching for a way to test a functionality to have an API name
mismatch.
> Also a show equivalent can be added to work in device level:
> "show device info"
>
I think it would be useful.
>
> [1]
> http://dpdk.org/ml/archives/dev/2017-August/072764.html
>
>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2017-08-28 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 14:37 Raslan Darawsheh
2017-08-23 15:09 ` Gaëtan Rivet
2017-08-23 16:18 ` Thomas Monjalon
2017-08-25 7:53 ` Gaëtan Rivet
2017-08-25 8:55 ` Thomas Monjalon
2017-08-28 9:55 ` Gaëtan Rivet
2017-08-28 10:30 ` Ferruh Yigit
2017-08-28 11:00 ` Thomas Monjalon
2017-08-28 11:12 ` Gaëtan Rivet [this message]
2017-09-07 8:17 ` Wu, Jingjing
2017-11-28 22:02 ` Ferruh Yigit
2017-12-03 9:32 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828111240.GF8124@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=rasland@mellanox.com \
--cc=salehals@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).