From: Jens Freimann <jfreimann@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, yliu@fridaylinux.org, maxime.coquelin@redhat.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix an incorrect behavior of device stop/start
Date: Wed, 30 Aug 2017 11:13:06 +0200 [thread overview]
Message-ID: <20170830091306.a5whdd7xrgb4jbtn@dhcp-192-218.str.redhat.com> (raw)
In-Reply-To: <20170829082601.30349-1-tiwei.bie@intel.com>
Hi Tiwei,
On Tue, Aug 29, 2017 at 04:26:01PM +0800, Tiwei Bie wrote:
>After starting a device, the driver shouldn't deliver the
>packets that already existed in the device before it is
>started to the applications. This patch fixes this issue
>by flushing the Rx queues when starting the device.
>
>Fixes: a85786dc816f ("virtio: fix states handling during initialization")
>Cc: stable@dpdk.org
>
>Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>---
> drivers/net/virtio/virtio_ethdev.c | 6 ++++++
> drivers/net/virtio/virtio_rxtx.c | 2 +-
> drivers/net/virtio/virtqueue.c | 25 +++++++++++++++++++++++++
> drivers/net/virtio/virtqueue.h | 5 +++++
> 4 files changed, 37 insertions(+), 1 deletion(-)
why don't we flush Tx queues as well?
>
>diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
>index e320811..6d60bc1 100644
>--- a/drivers/net/virtio/virtio_ethdev.c
>+++ b/drivers/net/virtio/virtio_ethdev.c
>@@ -1737,6 +1737,12 @@ virtio_dev_start(struct rte_eth_dev *dev)
> }
> }
>
>+ /* Flush the packets in Rx queues. */
>+ for (i = 0; i < dev->data->nb_rx_queues; i++) {
>+ rxvq = dev->data->rx_queues[i];
>+ virtqueue_flush(rxvq->vq);
>+ }
>+
A little bit further down is a for loop going over rx queues calling
notify. Could we flush directly before the notify and save the
additional loop?
regards,
Jens
next prev parent reply other threads:[~2017-08-30 9:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 8:26 Tiwei Bie
2017-08-30 9:13 ` Jens Freimann [this message]
2017-08-30 10:24 ` Tiwei Bie
2017-09-01 6:26 ` Jens Freimann
2017-09-01 7:14 ` Tiwei Bie
2017-10-19 13:53 ` Yuanhan Liu
2017-10-20 2:09 ` [dpdk-dev] [PATCH v2] " Tiwei Bie
2017-10-20 5:35 ` Yuanhan Liu
2017-11-14 17:38 ` Fischetti, Antonio
2017-12-01 17:17 ` Fischetti, Antonio
2017-12-02 4:30 ` Tiwei Bie
2017-12-04 7:19 ` Tiwei Bie
2017-12-04 11:46 ` Fischetti, Antonio
2017-12-05 3:11 ` Tiwei Bie
2017-12-05 8:52 ` Fischetti, Antonio
2017-12-02 1:24 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830091306.a5whdd7xrgb4jbtn@dhcp-192-218.str.redhat.com \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).