From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/failsafe: fix adding MAC error report miss
Date: Mon, 4 Sep 2017 10:47:30 +0200 [thread overview]
Message-ID: <20170904084730.GC21444@bidouze.vm.6wind.com> (raw)
In-Reply-To: <1504452405-63569-1-git-send-email-matan@mellanox.com>
On Sun, Sep 03, 2017 at 06:26:45PM +0300, Matan Azrad wrote:
> The corrupted code don't reply error in case of MAC
> address adding failure while failsafe PMD was trying
> to apply configuration to the sub device.
>
> Hence, the application may get unwanted packets.
>
> The fix adds error report for this case.
>
> Fixes: ebea83f899d8 ("net/failsafe: add plug-in support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> drivers/net/failsafe/failsafe_ether.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c
> index a3a8cce..fb9bbce 100644
> --- a/drivers/net/failsafe/failsafe_ether.c
> +++ b/drivers/net/failsafe/failsafe_ether.c
> @@ -203,6 +203,7 @@ fs_eth_dev_conf_apply(struct rte_eth_dev *dev,
>
> ether_format_addr(ea_fmt, ETHER_ADDR_FMT_SIZE, ea);
> ERROR("Adding MAC address %s failed", ea_fmt);
> + return ret;
> }
> }
> /* VLAN filter */
> --
> 2.7.4
>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2017-09-04 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 15:26 Matan Azrad
2017-09-04 8:47 ` Gaëtan Rivet [this message]
2017-09-05 15:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904084730.GC21444@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).