From: Stephen Hemminger <stephen@networkplumber.org>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] librte_mbuf: modify the port initialization value
Date: Mon, 4 Sep 2017 20:39:59 -0700 [thread overview]
Message-ID: <20170904203959.727ea76a@xeon-e3> (raw)
In-Reply-To: <20170904065532.13055-1-zhiyong.yang@intel.com>
On Mon, 4 Sep 2017 14:55:32 +0800
Zhiyong Yang <zhiyong.yang@intel.com> wrote:
> In order to support more than 256 virtual ports, the field "port" in
> rte_mbuf has been increased to 16 bits. The initialization/reset
> value of the field "port" should be changed from 0xff to 0xffff
> accordingly.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
> lib/librte_mbuf/rte_mbuf.c | 2 +-
> lib/librte_mbuf/rte_mbuf.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index 26a62b8e1..2e80ed9b1 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -144,7 +144,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
> /* init some constant fields */
> m->pool = mp;
> m->nb_segs = 1;
> - m->port = 0xff;
> + m->port = 0xffff;
> rte_mbuf_refcnt_set(m, 1);
> m->next = NULL;
> }
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index eaed7eee0..cdc70aa83 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1095,7 +1095,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf *m)
> m->vlan_tci = 0;
> m->vlan_tci_outer = 0;
> m->nb_segs = 1;
> - m->port = 0xff;
> + m->port = 0xffff;
>
> m->ol_flags = 0;
> m->packet_type = 0;
Maybe introduce MBUF_INVALID_PORT as a constant?
#define MBUF_INVALID_PORT 0xffff
next prev parent reply other threads:[~2017-09-05 3:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 6:55 Zhiyong Yang
2017-09-05 3:39 ` Stephen Hemminger [this message]
2017-09-05 4:28 ` Yang, Zhiyong
2017-09-05 5:13 ` [dpdk-dev] [PATCH v2] librte_mbuf: modify " Zhiyong Yang
2017-09-05 5:20 ` Zhang, Helin
2017-09-06 0:42 ` Yang, Zhiyong
2017-09-05 7:28 ` Thomas Monjalon
2017-09-05 12:30 ` Yang, Zhiyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904203959.727ea76a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).