From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Shachar Beiser <shacharbe@mellanox.com>
Cc: dev@dpdk.org, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value
Date: Tue, 5 Sep 2017 15:27:20 +0200 [thread overview]
Message-ID: <20170905132720.GD4301@6wind.com> (raw)
In-Reply-To: <a7cfb53050e6b67cacbc9c16e4cd3d9739367632.1504616614.git.shacharbe@mellanox.com>
Hi Shachar,
On Tue, Sep 05, 2017 at 01:04:38PM +0000, Shachar Beiser wrote:
> return value is sometimes returned uninitialized
>
> Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management")
> Fixes: b18042fb8f49 ("net/mlx5: fix misplaced Rx interrupts functions")
>
> Cc: adrien.mazarguil@6wind.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
Looks like in both commits, ret is properly initialized so I'm wondering if
the fixes line is right? Did you even get a compilation error?
Otherwise, you should drop this patch from the series.
> ---
> drivers/net/mlx5/mlx5_rxq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index 437dc02..24887fb 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -1330,7 +1330,7 @@
> struct priv *priv = mlx5_get_priv(dev);
> struct rxq *rxq = (*priv->rxqs)[rx_queue_id];
> struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);
> - int ret;
> + int ret = 0;
>
> if (!rxq || !rxq_ctrl->channel) {
> ret = EINVAL;
> --
> 1.8.3.1
>
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-09-05 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0027cb81572aa683b0db357dbfc62e810f1ae4c8.1504616614.git.shacharbe@mellanox.com>
[not found] ` <bf3a648369b1b8d2023819a1372c08c6cc5f0de8.1504525643.git.shacharbe@mellanox.com>
2017-09-04 11:48 ` [dpdk-stable] [PATCH 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
2017-09-04 15:15 ` Nélio Laranjeiro
2017-09-04 11:48 ` [dpdk-stable] [PATCH 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
2017-09-04 15:24 ` Nélio Laranjeiro
2017-09-05 9:04 ` Shachar Beiser
2017-09-05 13:04 ` [dpdk-stable] [PATCH v2 2/3] net/mlx5: fix TSO MLNX OFED 3.3 verification Shachar Beiser
2017-09-05 13:41 ` Nélio Laranjeiro
2017-09-14 13:43 ` [dpdk-stable] [PATCH v3 2/2] " Shachar Beiser
2017-09-17 10:42 ` [dpdk-stable] [PATCH v4 " Shachar Beiser
2017-09-18 17:52 ` [dpdk-stable] [dpdk-dev] " Yongseok Koh
2017-09-22 18:02 ` Ferruh Yigit
2017-09-05 13:04 ` [dpdk-stable] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value Shachar Beiser
2017-09-05 13:27 ` Adrien Mazarguil [this message]
2017-09-06 10:54 ` Shachar Beiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905132720.GD4301@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shacharbe@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).