From: Stephen Hemminger <stephen@networkplumber.org>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
Cc: Kevin Traynor <ktraynor@redhat.com>,
cristian.dumitrescu@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal
Date: Wed, 6 Sep 2017 08:37:15 -0700 [thread overview]
Message-ID: <20170906083715.2084ec8d@xeon-e3> (raw)
In-Reply-To: <20170906144133.GA21468@PBHAGAVATULA-LT>
On Wed, 6 Sep 2017 20:11:34 +0530
Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com> wrote:
> On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote:
> > On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote:
> > > From: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
> > >
> > > Currently, rte_reciprocal only supports unsigned 32bit divisors. This
> > > commit adds support for unsigned 64bit divisors.
> > >
> > > Rename unsigned 32bit specific functions appropriately and update
> > > librte_sched accordingly.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > ---
> > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 +-
> > > lib/librte_eal/common/include/rte_reciprocal.h | 109 ++++++++++++++++++++--
> > > lib/librte_eal/common/rte_reciprocal.c | 116 +++++++++++++++++++++---
> > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 3 +-
> > > lib/librte_sched/Makefile | 4 +-
> > > lib/librte_sched/rte_sched.c | 9 +-
> > > 6 files changed, 219 insertions(+), 25 deletions(-)
> > >
> > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> > > index 90d7258..59a85bb 100644
> > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> > > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
> > > @@ -241,6 +241,7 @@ EXPERIMENTAL {
> > > DPDK_17.11 {
> > > global:
> > >
> > > - rte_reciprocal_value;
> > > + rte_reciprocal_value_u32;
> > > + rte_reciprocal_value_u64;
> > >
> > > } DPDK_17.08;
> > > diff --git a/lib/librte_eal/common/include/rte_reciprocal.h b/lib/librte_eal/common/include/rte_reciprocal.h
> > > index b6d752f..85599e6 100644
> > > --- a/lib/librte_eal/common/include/rte_reciprocal.h
> > > +++ b/lib/librte_eal/common/include/rte_reciprocal.h
> >
> > Hi Pavan, sorry for commenting late but the license in v1 of this file
> > states it cannot be removed. It is not included in later versions - can
> > you explain why?
> >
> Hi Kevin,
>
> I have misinterpreted this mail
> http://dpdk.org/ml/archives/dev/2017-August/073781.html,
> any suggestion on how to proceed on this further?
>
> Thanks,
> Pavan
License issues need legal advice (TAB could ask LF if required).
Sorry, I am a cynic engineer not a lawyer.
Easiest solution is to find equivalent code in FreeBSD or some other project
which does not have the restrictions.
next prev parent reply other threads:[~2017-09-06 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 10:21 [dpdk-dev] [PATCH v6 1/3] eal: introduce integer divide through reciprocal Pavan Nikhilesh
2017-09-06 10:21 ` [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal Pavan Nikhilesh
2017-09-06 12:28 ` Kevin Traynor
2017-09-06 14:41 ` Pavan Nikhilesh Bhagavatula
2017-09-06 15:35 ` Kevin Traynor
2017-09-06 15:37 ` Stephen Hemminger [this message]
2017-09-06 17:05 ` Dumitrescu, Cristian
2017-09-20 13:15 ` Dumitrescu, Cristian
2017-09-06 10:21 ` [dpdk-dev] [PATCH v6 3/3] test: add tests for reciprocal based division Pavan Nikhilesh
2017-09-20 13:10 ` [dpdk-dev] [PATCH v6 1/3] eal: introduce integer divide through reciprocal Dumitrescu, Cristian
2017-09-20 13:27 ` Pavan Nikhilesh Bhagavatula
2017-09-07 9:08 [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal Pavan Nikhilesh Bhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906083715.2084ec8d@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).