From: Shijith Thotton <shijith.thotton@caviumnetworks.com>
To: "Yang, Qiming" <qiming.yang@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
"Thotton, Shijith" <Shijith.Thotton@cavium.com>,
"Hu, Xuekun" <xuekun.hu@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Patil, Harish" <Harish.Patil@cavium.com>,
Gregory Etelson <gregory@weka.io>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file
Date: Fri, 15 Sep 2017 15:01:19 +0530 [thread overview]
Message-ID: <20170915093118.GA6367@localhost.localdomain> (raw)
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7EA492@SHSMSX151.ccr.corp.intel.com>
On Fri, Sep 15, 2017 at 09:18:00AM +0000, Yang, Qiming wrote:
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Friday, September 15, 2017 4:43 PM
> > To: Yang, Qiming <qiming.yang@intel.com>
> > Cc: dev@dpdk.org; Tan, Jianfeng <jianfeng.tan@intel.com>; Thotton, Shijith
> > <Shijith.Thotton@cavium.com>; Hu, Xuekun <xuekun.hu@intel.com>; Yigit,
> > Ferruh <ferruh.yigit@intel.com>; Patil, Harish <Harish.Patil@cavium.com>;
> > Gregory Etelson <gregory@weka.io>; stable@dpdk.org
> > Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open
> > and release of device file
> >
> > Hi
> >
> > 15/09/2017 10:04, Yang, Qiming:
> > > Hi, Thomas
> > > We meet a urgent issue because of Shijith's patch.
> > > When use DPDK version 17.08, DPDK VF driver and kernel PF driver, i40e, ixgbe
> > and qede(Harish said) VF all meet initial failure.
> >
> > This patch has been integrated in DPDK 17.08-rc2 (2 months ago).
> > Why a so obvious issue is discovered only now?
> >
> > > This issue only occurred when use 17.08 igb_uio, vfio-pci and 17.05 igb_uio all
> > works well.
> > > Considering this issue will block our vf driver develop and test work, could we
> > revert this patch first and find another appropriate way?
> >
> > We need to be sure the revert is the right solution because it will be backported
> > to the stable 17.08 release.
> >
> > Shijith suggests to "try removing pci_reset_function from igbuio_pci_open."
> > Can we try this first?
> > Are we sure the bug is not in new firmwares?
>
> I have tried to remove pci_reset_function, it works in my environment, but it doesn't work in someone's enviroment.
> And removing this function won't it changes the original purpose of his patch? So I'm not sure it is a good solution.
> This bug is not a firmware version related issue, we can reproduce stably with older firmware.
>
There is a reset during release which was suggested as a fix by Gregory for an
issue he faced with i40e VF[1]. Removing it can cause problems for him.
1. http://dpdk.org/ml/archives/dev/2017-May/066317.html
next prev parent reply other threads:[~2017-09-15 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7E0E71@SHSMSX101.ccr.corp.intel.com>
[not found] ` <D5DED7B9.160793%Harish.Patil@cavium.com>
[not found] ` <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7EA3EB@SHSMSX151.ccr.corp.intel.com>
2017-09-15 8:42 ` Thomas Monjalon
2017-09-15 9:18 ` Yang, Qiming
2017-09-15 9:25 ` Ferruh Yigit
2017-09-15 9:31 ` Shijith Thotton [this message]
2017-09-19 10:24 ` [dpdk-stable] [PATCH] igb_uio: remove PCI reset during uio device open Shijith Thotton
2017-09-20 16:52 ` Ferruh Yigit
2017-09-21 10:00 ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
2017-09-22 2:47 ` [dpdk-stable] " Yang, Qiming
2017-09-29 12:57 ` [dpdk-stable] [dpdk-dev] " Wu, Jingjing
2017-10-02 18:24 ` Shijith Thotton
2017-10-03 11:35 ` Gregory Etelson
2017-10-13 14:36 ` Shijith Thotton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915093118.GA6367@localhost.localdomain \
--to=shijith.thotton@caviumnetworks.com \
--cc=Harish.Patil@cavium.com \
--cc=Shijith.Thotton@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gregory@weka.io \
--cc=jianfeng.tan@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xuekun.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).