From: Bruce Richardson <bruce.richardson@intel.com>
To: Vladimir Kuramshin <v.kuramshin@samsung.com>
Cc: tomasz.kantecki@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] examples/l2fwd-cat: fix build according to API changes
Date: Tue, 19 Sep 2017 09:56:19 +0100 [thread overview]
Message-ID: <20170919085619.GA17536@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20170919081731.23970-1-v.kuramshin@samsung.com>
On Tue, Sep 19, 2017 at 11:17:31AM +0300, Vladimir Kuramshin wrote:
> Current version is compatible with PQOS version 1.3
> but not compatible with higher versions. This change
> makes l2fwd-cat example compatible with versions since 1.4
>
> Signed-off-by: Vladimir Kuramshin <v.kuramshin@samsung.com>
> ---
> examples/l2fwd-cat/Makefile | 5 +--
> examples/l2fwd-cat/cat.c | 85 +++++++++++++++++++++++++++++++++++++++------
> 2 files changed, 76 insertions(+), 14 deletions(-)
>
> diff --git a/examples/l2fwd-cat/Makefile b/examples/l2fwd-cat/Makefile
> index ae921ade6..a7fe6d68e 100644
> --- a/examples/l2fwd-cat/Makefile
> +++ b/examples/l2fwd-cat/Makefile
> @@ -40,9 +40,6 @@ endif
> # Default target, can be overridden by command line or environment
> RTE_TARGET ?= x86_64-native-linuxapp-gcc
>
> -# Location of PQoS library and includes,
> -PQOS_LIBRARY_PATH = $(PQOS_INSTALL_PATH)/libpqos.a
> -
> include $(RTE_SDK)/mk/rte.vars.mk
>
> # binary name
> @@ -65,6 +62,6 @@ CFLAGS += -I$(PQOS_INSTALL_PATH)/../include
> CFLAGS_cat.o := -D_GNU_SOURCE
>
> LDLIBS += -L$(PQOS_INSTALL_PATH)
> -LDLIBS += $(PQOS_LIBRARY_PATH)
> +LDLIBS += -lpqos
>
> include $(RTE_SDK)/mk/rte.extapp.mk
> diff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c
> index 6133bf5bb..9330b2d26 100644
> --- a/examples/l2fwd-cat/cat.c
> +++ b/examples/l2fwd-cat/cat.c
> @@ -53,7 +53,11 @@
> static const struct pqos_cap *m_cap;
> static const struct pqos_cpuinfo *m_cpu;
> static const struct pqos_capability *m_cap_l3ca;
> +#if PQOS_VERSION <= 10300
> static unsigned m_sockets[PQOS_MAX_SOCKETS];
> +#else
> +static unsigned int *m_sockets;
> +#endif
Does this check work right? The version number in git right now seems to
be just 10100, which would use the "old" path here, despite being latest
code? https://github.com/01org/intel-cmt-cat/blob/master/lib/pqos.h
I will try and follow up with the maintainers of the pqos files, and see
how the version numbers in pqos.h are meant to work.
Regards,
/Bruce
next prev parent reply other threads:[~2017-09-19 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170829095235eucas1p1c53a2ad6ba980aad25d51dfb6c6b8dd7@eucas1p1.samsung.com>
2017-08-29 9:51 ` [dpdk-dev] [PATCH] " Vladimir Kuramshin
[not found] ` <CGME20170907114552eucas1p182c484310d70f1d52f64b9ea7fb96ed6@eucas1p1.samsung.com>
2017-09-07 11:45 ` [dpdk-dev] [PATCH v2] " Vladimir Kuramshin
2017-09-18 14:49 ` Bruce Richardson
2017-09-18 16:07 ` Vladimir Kuramshin
2017-09-18 16:18 ` Bruce Richardson
[not found] ` <CGME20170919081803eucas1p255aac78e316693ea52c85e31bbfcc81b@eucas1p2.samsung.com>
2017-09-19 8:17 ` [dpdk-dev] [PATCH v3] " Vladimir Kuramshin
2017-09-19 8:56 ` Bruce Richardson [this message]
2017-09-19 9:23 ` Vladimir Kuramshin
[not found] ` <CGME20170919094052eucas1p12138437b5d1f66086b82c98cd1464e37@eucas1p1.samsung.com>
2017-09-19 9:40 ` [dpdk-dev] [PATCH v4] " Vladimir Kuramshin
2017-09-19 10:47 ` Bruce Richardson
2017-10-13 22:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919085619.GA17536@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=tomasz.kantecki@intel.com \
--cc=v.kuramshin@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).