From: Olivier MATZ <olivier.matz@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] devtools: rework abi checker script
Date: Tue, 19 Sep 2017 11:15:12 +0200 [thread overview]
Message-ID: <20170919091511.ildim4ds2lv7sy4d@neon> (raw)
In-Reply-To: <20170913150013.GB4320@hmswarspite.think-freely.org>
Hi Neil,
On Wed, Sep 13, 2017 at 11:00:13AM -0400, Neil Horman wrote:
> On Mon, Sep 11, 2017 at 10:46:35AM +0200, Olivier Matz wrote:
> > The initial version of the script had some limitations:
> > - cannot work on a non-clean workspace
> > - environment variables are not documented
> > - no compilation log in case of failure
> > - return success even it abi is incompatible
> >
> > This patch addresses these issues and rework the code.
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> >
> > v2->v3:
> > - fix when not launched from dpdk root dir
> > - use "-Og -Wno-error" instead of "-O0"
> > - fix typo in commit log
> >
> > v1->v2:
> > - use /usr/bin/env to find bash (which is required)
> > - fix displayed path to html reports
> > - reword help for -f option
> >
> > devtools/validate-abi.sh | 392 ++++++++++++++++++++++++-----------------------
> > 1 file changed, 200 insertions(+), 192 deletions(-)
> >
>
> This is alot closer, I think theres just a little wierdness left. When running
> this checker script, the end of the log shows this:
>
> CMD: abi-compliance-checker -l librte_vhost.so -old /home/nhorman/git/dpdk/devtools/abi-check/222555480/librte_vhost.so.dump -new /home/nhorman/git/dpdk/devtools/abi-check/02657b4ad/librte_vhost.so.dump
> NOTICE: At least one call to abi-compliance-checker returned an error.
> NOTICE: ABI may be incompatible, please check logs for details.
> NOTICE: Incompatible list: librte_cryptodev.so librte_eal.so librte_efd.so librte_ethdev.so librte_eventdev.so librte_hash.so librte_pdump.so librte_pmd_crypto_scheduler.so librte_pmd_ring.so librte_ring.so
>
> Which I think is something of a false positive. The line:
> NOTICE: At least one call to abi-compliance-checker returned an error.
>
> I think is emitted simply because abi-compilance-checker returns non-zero and
> reports that error if it finds any incompatibilities. I'm not sure we want to
> flag that as an error per se. It gives the impression something has gone wrong,
> rather than correctly identifying that there are incompatibilities.
>
> Though on the other hand, maybe we do want to set that red flag so people look
> at what the incompatibilities are. As I say it out loud, perhaps that
> preferable.
Yes, I can remove this line
"At least one call to abi-compliance-checker returned an error."
which does not give a lot of info anyway.
While reproducing the issue, I also realized that the report path
was not preoperly fixed. So I'm sending a v4 with these fixes.
Thanks,
Olivier
next prev parent reply other threads:[~2017-09-19 9:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 13:51 [dpdk-dev] [PATCH] " Olivier Matz
2017-09-04 16:00 ` Bruce Richardson
2017-09-04 16:03 ` Bruce Richardson
2017-09-04 16:13 ` Bruce Richardson
2017-09-06 14:51 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2017-09-08 13:46 ` Neil Horman
2017-09-11 8:18 ` Olivier MATZ
2017-09-11 8:46 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2017-09-13 15:00 ` Neil Horman
2017-09-19 9:15 ` Olivier MATZ [this message]
2017-09-20 9:12 ` [dpdk-dev] [PATCH v4] " Olivier Matz
2017-09-21 15:40 ` Neil Horman
2017-09-25 9:11 ` Olivier MATZ
2017-09-25 11:21 ` Neil Horman
2017-10-05 7:53 ` [dpdk-dev] [PATCH v5] " Olivier Matz
2017-10-05 13:15 ` Neil Horman
2017-11-07 23:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919091511.ildim4ds2lv7sy4d@neon \
--to=olivier.matz@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).