From: Yuanhan Liu <yliu@fridaylinux.org>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com
Subject: Re: [dpdk-dev] [PATCH 11/12] net/vhost: support to run in the secondary process
Date: Thu, 21 Sep 2017 12:29:28 +0800 [thread overview]
Message-ID: <20170921042927.GB2251@yliu-home> (raw)
In-Reply-To: <1503654052-84730-12-git-send-email-jianfeng.tan@intel.com>
On Fri, Aug 25, 2017 at 09:40:51AM +0000, Jianfeng Tan wrote:
> static int
> +share_device(int vid)
> +{
> + uint32_t i, vring_num;
> + int len;
> + int fds[8];
> + struct rte_vhost_memory *mem;
> + struct vhost_params *params;
> + struct rte_vhost_vring vring;
> +
> + /* share mem table */
> + if (rte_vhost_get_mem_table(vid, &mem) < 0) {
> + printf("Failed to get mem table\n");
No printf in DPDK lib and pmd, use RTE_LOG instead.
[...]
> +static int
> +eth_dev_vhost_attach(struct rte_vdev_device *dev)
> +{
> + struct rte_eth_dev *eth_dev = NULL;
> + struct rte_eth_dev_data *data = NULL;
> +
> + RTE_LOG(INFO, PMD, "Attach vhost user port\n");
> +
> + /* reserve an ethdev entry */
> + eth_dev = rte_eth_vdev_allocate(dev, sizeof(struct pmd_internal));
> + if (eth_dev == NULL)
> + goto error;
I'd suggest to "return -1" directly here, without introducing goto.
> +
> + eth_dev->dev_ops = &ops;
> +
> + /* finally assign rx and tx ops */
> + eth_dev->rx_pkt_burst = eth_vhost_rx;
> + eth_dev->tx_pkt_burst = eth_vhost_tx;
> +
> + data = eth_dev->data;
> +
> + return data->port_id;
> +
> +error:
> + return -1;
> +}
> +
> static inline int
> open_iface(const char *key __rte_unused, const char *value, void *extra_args)
> {
> @@ -1154,6 +1244,39 @@ open_int(const char *key __rte_unused, const char *value, void *extra_args)
> }
>
> static int
> +vhost_pmd_action(const char *params, int len __rte_unused,
> + int fds[], int fds_num)
> +{
> + int i;
> + void *base_addr;
> + const struct vhost_params *p = (const struct vhost_params *)params;
The cast could be avoided if you define the action prototype with
"const void *params".
> + const struct rte_vhost_mem_region *regions;
> +
> + switch (p->type) {
> + case VHOST_MSG_TYPE_REGIONS:
> + regions = (const void *)p->regions;
Unnecessary cast.
> + for (i = 0; i < fds_num; ++i) {
> + base_addr = mmap(regions[i].mmap_addr,
> + regions[i].mmap_size,
> + PROT_READ | PROT_WRITE,
> + MAP_FIXED | MAP_SHARED, fds[i], 0);
> + if (base_addr != regions[i].mmap_addr) {
> + RTE_LOG(INFO, PMD, "mmap error");
The log level should be error, nothing will work if it happens. Also, the
log message should be more informative.
--yliu
next prev parent reply other threads:[~2017-09-21 4:29 UTC|newest]
Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 9:40 [dpdk-dev] [PATCH 00/12] support to run vdev " Jianfeng Tan
2017-08-25 9:40 ` [dpdk-dev] [PATCH 01/12] cryptodev: remove crypto vdev init Jianfeng Tan
2017-09-18 11:48 ` De Lara Guarch, Pablo
2017-08-25 9:40 ` [dpdk-dev] [PATCH 02/12] eal: avoid calling rte_vdev_init() Jianfeng Tan
2017-08-29 12:50 ` Gaëtan Rivet
2017-08-29 22:25 ` Tan, Jianfeng
2017-08-25 9:40 ` [dpdk-dev] [PATCH 03/12] crypto: move vdev helper functions into dedicated file Jianfeng Tan
2017-09-18 11:51 ` De Lara Guarch, Pablo
2017-08-25 9:40 ` [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus Jianfeng Tan
2017-08-29 13:04 ` Gaëtan Rivet
2017-08-29 22:47 ` Tan, Jianfeng
2017-09-18 11:47 ` De Lara Guarch, Pablo
2017-09-19 6:01 ` Tan, Jianfeng
2017-08-25 9:40 ` [dpdk-dev] [PATCH 05/12] bus/vdev: change log type from EAL to PMD Jianfeng Tan
2017-08-29 12:54 ` Gaëtan Rivet
2017-08-29 22:27 ` Tan, Jianfeng
2017-08-25 9:40 ` [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication Jianfeng Tan
2017-09-18 13:49 ` Jiayu Hu
2017-09-21 6:11 ` Tan, Jianfeng
2017-09-20 3:00 ` Jiayu Hu
2017-09-21 6:53 ` Tan, Jianfeng
2017-09-27 12:19 ` Yuanhan Liu
2017-09-28 13:50 ` Tan, Jianfeng
2017-09-29 1:24 ` Yuanhan Liu
2017-09-29 10:09 ` Burakov, Anatoly
2017-09-29 10:25 ` Yuanhan Liu
2017-08-25 9:40 ` [dpdk-dev] [PATCH 07/12] bus/vdev: scan and probe vdev in secondary processes Jianfeng Tan
2017-08-25 9:40 ` [dpdk-dev] [PATCH 08/12] ethdev: support attach vdev in secondary process Jianfeng Tan
2017-08-25 9:40 ` [dpdk-dev] [PATCH 09/12] vhost: allocate virtio_net in memzone Jianfeng Tan
2017-08-25 9:40 ` [dpdk-dev] [PATCH 10/12] vhost: support to kick in secondary process Jianfeng Tan
2017-09-21 3:33 ` Yuanhan Liu
2017-09-21 7:04 ` Tan, Jianfeng
2017-09-21 9:17 ` Yuanhan Liu
2017-09-22 2:30 ` Tan, Jianfeng
2017-09-27 9:36 ` Yuanhan Liu
2017-09-28 5:10 ` Tan, Jianfeng
2017-09-28 8:09 ` Tan, Jianfeng
2017-09-30 8:18 ` Yuanhan Liu
2017-09-30 10:50 ` Tan, Jianfeng
2017-08-25 9:40 ` [dpdk-dev] [PATCH 11/12] net/vhost: support to run in the " Jianfeng Tan
2017-09-21 4:29 ` Yuanhan Liu [this message]
2017-08-25 9:40 ` [dpdk-dev] [PATCH 12/12] examples/helloworld: do not exit automatically Jianfeng Tan
2017-09-18 11:44 ` De Lara Guarch, Pablo
2017-09-19 5:07 ` Tan, Jianfeng
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 00/12] support to run vdev in the secondary process Jianfeng Tan
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 01/12] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 02/12] eal: avoid calling rte_vdev_init() Jianfeng Tan
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 03/12] cryptodev: avoid dependency on rte_vdev.h Jianfeng Tan
2017-10-05 13:13 ` Jan Blunck
2017-10-09 1:04 ` Tan, Jianfeng
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 04/12] bus/fslmc: introduce RTE_LOGTYPE_BUS for bus drivers Jianfeng Tan
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 05/12] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 06/12] bus/vdev: normalize log type Jianfeng Tan
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 07/12] eal: add channel for primary/secondary communication Jianfeng Tan
2017-09-28 15:01 ` Ananyev, Konstantin
2017-09-28 15:29 ` Burakov, Anatoly
2017-09-29 1:03 ` Tan, Jianfeng
2017-09-29 10:00 ` Burakov, Anatoly
2017-09-30 4:07 ` Tan, Jianfeng
2017-10-02 10:08 ` Burakov, Anatoly
2017-10-05 12:01 ` Jan Blunck
2017-10-09 1:27 ` Tan, Jianfeng
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 08/12] bus/vdev: scan and probe vdev in secondary processes Jianfeng Tan
2017-10-05 13:04 ` Jan Blunck
2017-10-09 1:08 ` Tan, Jianfeng
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 09/12] ethdev: support attach vdev in secondary process Jianfeng Tan
2017-10-05 14:26 ` Jan Blunck
2017-10-09 0:56 ` Tan, Jianfeng
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 10/12] vhost: allocate virtio_net in memzone Jianfeng Tan
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 11/12] vhost: support to kick in secondary process Jianfeng Tan
2017-09-28 13:55 ` [dpdk-dev] [PATCH v2 12/12] net/vhost: support to run in the " Jianfeng Tan
2017-09-29 8:28 ` Yuanhan Liu
2017-09-30 4:03 ` Tan, Jianfeng
2017-09-30 8:16 ` Yuanhan Liu
2017-09-30 10:06 ` Tan, Jianfeng
2017-09-30 11:49 ` Yuanhan Liu
2017-10-01 23:48 ` Tan, Jianfeng
2017-09-30 8:23 ` Yuanhan Liu
2017-09-30 10:53 ` Tan, Jianfeng
2017-09-30 11:34 ` Yuanhan Liu
2017-10-01 23:46 ` Tan, Jianfeng
2017-10-09 3:20 ` [dpdk-dev] [PATCH v3 0/5] move vdev into drivers/bus Jianfeng Tan
2017-10-09 3:20 ` [dpdk-dev] [PATCH v3 1/5] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-10-09 3:20 ` [dpdk-dev] [PATCH v3 2/5] eal: avoid calling rte_vdev_init() Jianfeng Tan
2017-10-09 3:20 ` [dpdk-dev] [PATCH v3 3/5] bus: introduce RTE_LOGTYPE_BUS for bus drivers Jianfeng Tan
2017-10-09 3:20 ` [dpdk-dev] [PATCH v3 4/5] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-10-09 3:20 ` [dpdk-dev] [PATCH v3 5/5] bus/vdev: normalize log type Jianfeng Tan
2017-10-09 10:55 ` [dpdk-dev] [PATCH v4 0/5] move vdev into drivers/bus Jianfeng Tan
2017-10-09 10:55 ` [dpdk-dev] [PATCH v4 1/5] bus/vdev: scan and probe vdev in secondary processes Jianfeng Tan
2017-10-09 10:55 ` [dpdk-dev] [PATCH v4 2/5] ethdev: support attach vdev in secondary process Jianfeng Tan
2017-10-09 10:55 ` [dpdk-dev] [PATCH v4 3/5] vhost: allocate virtio_net in memzone Jianfeng Tan
2017-10-09 10:55 ` [dpdk-dev] [PATCH v4 4/5] vhost: support to kick in secondary process Jianfeng Tan
2017-10-09 10:55 ` [dpdk-dev] [PATCH v4 5/5] net/vhost: support to run in the " Jianfeng Tan
2017-10-09 11:08 ` [dpdk-dev] [PATCH v4 0/5] move vdev into drivers/bus Tan, Jianfeng
2017-10-09 11:27 ` [dpdk-dev] [PATCH v5 " Jianfeng Tan
2017-10-09 11:27 ` [dpdk-dev] [PATCH v5 1/5] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-10-09 11:27 ` [dpdk-dev] [PATCH v5 2/5] eal: remove dependency on vdev Jianfeng Tan
2017-10-09 11:27 ` [dpdk-dev] [PATCH v5 3/5] bus: introduce new log type for bus drivers Jianfeng Tan
2017-10-11 6:54 ` Shreyansh Jain
2017-10-11 10:42 ` Tan, Jianfeng
2017-10-11 11:20 ` Shreyansh Jain
2017-10-12 2:14 ` Tan, Jianfeng
2017-10-09 11:27 ` [dpdk-dev] [PATCH v5 4/5] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-10-09 11:27 ` [dpdk-dev] [PATCH v5 5/5] bus/vdev: normalize log type Jianfeng Tan
2017-10-12 8:46 ` [dpdk-dev] [PATCH v6 0/4] move vdev into drivers/bus Jianfeng Tan
2017-10-12 8:46 ` [dpdk-dev] [PATCH v6 1/4] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-10-12 10:06 ` Thomas Monjalon
2017-10-12 8:46 ` [dpdk-dev] [PATCH v6 2/4] eal: remove dependency on vdev Jianfeng Tan
2017-10-12 8:46 ` [dpdk-dev] [PATCH v6 3/4] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-10-12 8:46 ` [dpdk-dev] [PATCH v6 4/4] bus/vdev: change log type Jianfeng Tan
2017-10-13 2:04 ` [dpdk-dev] [PATCH v7 0/4] move vdev into drivers/bus Jianfeng Tan
2017-10-13 2:04 ` [dpdk-dev] [PATCH v7 1/4] ethdev: support attach vdev in secondary process Jianfeng Tan
2017-10-13 2:04 ` [dpdk-dev] [PATCH v7 2/4] vhost: allocate virtio_net in memzone Jianfeng Tan
2017-10-13 2:04 ` [dpdk-dev] [PATCH v7 3/4] vhost: support to kick in secondary process Jianfeng Tan
2017-10-13 2:04 ` [dpdk-dev] [PATCH v7 4/4] net/vhost: support to run in the " Jianfeng Tan
2017-10-13 8:26 ` [dpdk-dev] [PATCH v7 0/4] move vdev into drivers/bus Thomas Monjalon
2017-10-13 11:49 ` Tan, Jianfeng
2017-10-13 11:51 ` Jianfeng Tan
2017-10-13 11:51 ` [dpdk-dev] [PATCH v7 1/4] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-10-23 10:06 ` De Lara Guarch, Pablo
2017-10-13 11:51 ` [dpdk-dev] [PATCH v7 2/4] eal: remove dependency on vdev Jianfeng Tan
2017-10-13 11:52 ` [dpdk-dev] [PATCH v7 3/4] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-10-23 14:34 ` De Lara Guarch, Pablo
2017-10-13 11:52 ` [dpdk-dev] [PATCH v7 4/4] bus/vdev: change log type Jianfeng Tan
2017-10-25 17:10 ` [dpdk-dev] [PATCH v8 0/4] move vdev into drivers/bus Jianfeng Tan
2017-10-25 17:10 ` [dpdk-dev] [PATCH v8 1/4] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-10-25 17:10 ` [dpdk-dev] [PATCH v8 2/4] eal: remove dependency on vdev Jianfeng Tan
2017-10-25 17:10 ` [dpdk-dev] [PATCH v8 3/4] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-10-25 21:32 ` De Lara Guarch, Pablo
2017-10-25 23:03 ` Gaëtan Rivet
2017-10-25 17:10 ` [dpdk-dev] [PATCH v8 4/4] bus/vdev: change log type Jianfeng Tan
2017-10-27 1:06 ` [dpdk-dev] [PATCH v0 0/4] move vdev into drivers/bus Jianfeng Tan
2017-10-27 1:06 ` [dpdk-dev] [PATCH v9 1/4] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-10-27 1:06 ` [dpdk-dev] [PATCH v9 2/4] eal: remove dependency on vdev Jianfeng Tan
2017-10-27 1:06 ` [dpdk-dev] [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-10-27 7:56 ` Thomas Monjalon
2017-10-27 8:19 ` Tan, Jianfeng
2017-10-27 8:53 ` Thomas Monjalon
2017-10-27 16:57 ` Gaëtan Rivet
2017-10-27 1:06 ` [dpdk-dev] [PATCH v9 4/4] bus/vdev: change log type Jianfeng Tan
2017-10-27 3:23 ` [dpdk-dev] [PATCH v10 0/4] move vdev into drivers/bus Jianfeng Tan
2017-10-27 3:23 ` [dpdk-dev] [PATCH v10 1/4] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-10-27 3:23 ` [dpdk-dev] [PATCH v10 2/4] eal: remove dependency on vdev Jianfeng Tan
2017-10-27 3:23 ` [dpdk-dev] [PATCH v10 3/4] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-10-27 3:23 ` [dpdk-dev] [PATCH v10 4/4] bus/vdev: change log type Jianfeng Tan
2017-10-30 8:28 ` [dpdk-dev] [PATCH v11 0/4] move vdev into drivers/bus Jianfeng Tan
2017-10-30 8:28 ` [dpdk-dev] [PATCH v11 1/4] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-10-30 8:28 ` [dpdk-dev] [PATCH v11 2/4] eal: remove dependency on vdev Jianfeng Tan
2017-10-30 8:28 ` [dpdk-dev] [PATCH v11 3/4] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-11-07 2:43 ` Thomas Monjalon
2017-11-07 6:21 ` Tan, Jianfeng
2017-10-30 8:28 ` [dpdk-dev] [PATCH v11 4/4] bus/vdev: change log type Jianfeng Tan
2017-11-07 6:54 ` [dpdk-dev] [PATCH v12 0/4] move vdev into drivers/bus Jianfeng Tan
2017-11-07 6:54 ` [dpdk-dev] [PATCH v12 1/4] cryptodev: remove crypto vdev init API Jianfeng Tan
2017-11-07 6:54 ` [dpdk-dev] [PATCH v12 2/4] eal: remove dependency on vdev Jianfeng Tan
2017-11-07 6:54 ` [dpdk-dev] [PATCH v12 3/4] bus/vdev: move to vdev bus to drivers/bus Jianfeng Tan
2017-11-07 6:54 ` [dpdk-dev] [PATCH v12 4/4] bus/vdev: change log type Jianfeng Tan
2017-11-07 15:43 ` [dpdk-dev] [PATCH v12 0/4] move vdev into drivers/bus Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921042927.GB2251@yliu-home \
--to=yliu@fridaylinux.org \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mtetsuyah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).