From: Jan Viktorin <viktorin@rehivetech.com>
To: Lukasz Majczak <lma@semihalf.com>
Cc: chaozhu@linux.vnet.ibm.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] librte_eal: fix wrong assert for arm and ppc
Date: Fri, 22 Sep 2017 10:31:03 +0200 [thread overview]
Message-ID: <20170922103103.2ef17602.viktorin@rehivetech.com> (raw)
In-Reply-To: <20170921155953.9984-1-lma@semihalf.com>
On Thu, 21 Sep 2017 17:59:53 +0200
Lukasz Majczak <lma@semihalf.com> wrote:
> The assertion of return value from the open() function is done against
> 0, while it is a correct value - open() returns -1 in case of an error.
> It causes problems while trying to run as a daemon, in which case, this
> call to open() will return 0 as a valid descriptor.
I'd put an empty line here...
> Fixes: b94e5c9406b5 ("eal/arm: add CPU flags for ARMv7")
> Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
> Fixes: 9ae155385686 ("eal/ppc: cpu flag checks for IBM Power")
>
> Signed-off-by: Lukasz Majczak <lma@semihalf.com>
Acked-by: Jan Viktorin <viktorin@rehivetech.com>
next prev parent reply other threads:[~2017-09-22 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 15:59 Lukasz Majczak
2017-09-22 8:31 ` Jan Viktorin [this message]
2017-09-25 7:34 ` [dpdk-dev] [PATCH v3] " Lukasz Majczak
2017-09-28 2:01 ` Chao Zhu
2017-09-28 6:54 ` [dpdk-dev] [PATCH v4] " Lukasz Majczak
2017-10-05 22:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922103103.2ef17602.viktorin@rehivetech.com \
--to=viktorin@rehivetech.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=lma@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).