From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Nikhil Rao <nikhil.rao@intel.com>,
dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v6 3/7] eventdev: add eth Rx adapter caps function to SW PMD
Date: Wed, 11 Oct 2017 08:27:20 +0530 [thread overview]
Message-ID: <20171011025719.GA1933@jerin> (raw)
In-Reply-To: <1760785.loeYggim5W@xps>
-----Original Message-----
> Date: Wed, 11 Oct 2017 01:16:25 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Nikhil Rao <nikhil.rao@intel.com>
> Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com
> Subject: Re: [dpdk-dev] [PATCH v6 3/7] eventdev: add eth Rx adapter caps
> function to SW PMD
>
> Hi,
>
> 11/10/2017 00:21, Nikhil Rao:
> > --- a/lib/librte_eventdev/rte_eventdev_pmd.h
> > +++ b/lib/librte_eventdev/rte_eventdev_pmd.h
> > @@ -83,6 +83,14 @@ extern "C" {
> > } \
> > } while (0)
> >
> > +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \
> > + ((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | \
> > + (RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ))
> > +
> > +/**< Ethernet Rx adapter cap to return If the packet transfers from
> > + * the ethdev to eventdev use a SW service function
> > + */
>
> It is a value specific to the SW driver.
> I think it should not be defined in librte_eventdev.
It should be defined in librte_eventdev as HW drivers use this flag
if HW adapter needs to use SW for fallback.
Already discussed this at
http://dpdk.org/ml/archives/dev/2017-September/075302.html
See HW driver usage as example for dpaa2.
http://dpdk.org/ml/archives/dev/2017-October/078391.html
function: dpaa2_eventdev_eth_caps_get
>
> Do you mind to move it for RC2?
next prev parent reply other threads:[~2017-10-11 2:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 22:21 [dpdk-dev] [PATCH v6 0/7] eventdev: cover letter: eth Rx adapter Nikhil Rao
2017-10-10 16:26 ` Jerin Jacob
2017-10-10 16:49 ` Jerin Jacob
2017-10-10 22:21 ` [dpdk-dev] [PATCH v6 1/7] eventdev: add caps API and PMD callback for " Nikhil Rao
2017-10-10 22:21 ` [dpdk-dev] [PATCH v6 2/7] eventdev: add PMD callbacks " Nikhil Rao
2017-10-10 22:21 ` [dpdk-dev] [PATCH v6 3/7] eventdev: add eth Rx adapter caps function to SW PMD Nikhil Rao
2017-10-10 23:16 ` Thomas Monjalon
2017-10-11 2:57 ` Jerin Jacob [this message]
2017-10-10 22:21 ` [dpdk-dev] [PATCH v6 4/7] eventdev: add eth Rx adapter API header Nikhil Rao
2017-10-10 22:21 ` [dpdk-dev] [PATCH v6 5/7] eventdev: add event type for eth Rx adapter Nikhil Rao
2017-10-10 22:21 ` [dpdk-dev] [PATCH v6 6/7] eventdev: add eth Rx adapter implementation Nikhil Rao
2017-10-10 22:21 ` [dpdk-dev] [PATCH v6 7/7] eventdev: add tests for eth Rx adapter APIs Nikhil Rao
2017-10-10 14:05 ` Jerin Jacob
2017-10-10 23:24 ` Nikhil Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011025719.GA1933@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).