From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>,
dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 00/26] DPDK PMD for OCTEONTX NW device
Date: Wed, 11 Oct 2017 16:28:52 +0530 [thread overview]
Message-ID: <20171011105848.GA20722@jerin> (raw)
In-Reply-To: <5089301.2kQRttag8V@xps>
-----Original Message-----
> Date: Wed, 11 Oct 2017 12:35:27 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
> jerin.jacob@caviumnetworks.com
> Subject: Re: [dpdk-dev] [PATCH v2 00/26] DPDK PMD for OCTEONTX NW device
>
> 09/10/2017 04:07, Ferruh Yigit:
> > On 10/8/2017 1:44 PM, Santosh Shukla wrote:
> > > v2:
> > > Includes Minor changes like:
> > > - Incorporated minor review comment (Suggested y John)
> > > - Added correct pool handle ops name i.e. from mbuf-pool-ops to
> > > mbuf-pool-ops-name in the doc.
> > > - Rebased on Octeontx-fpavf v3 series and tested for same.
> > > - Refer[7]: rebased (octeontx PMD + octeontx_fpavf mempool pmd) on upstream
> > > tip commit : 3fb1ea032bd6ff8317af5dac9af901f1f324cab4.
> > >
> > > v1:
> > > This patch set provides the initial version of DPDK PMD for the
> > > integrated NIC device found in Cavium OCTEONTX SoC(CN83xx) family.
> > >
> > > Introduction to OCTEONTX ARM processors can be found
> > > here: http://www.cavium.com/OCTEON-TX_ARM_Processors.html
> > >
> > > OCTEONTX SoC family has two types of NIC controllers,
> > > 1) nicvf HW, Which is more like traditional NIC(no NPU HW accelerators)
> > > http://dpdk.org/doc/guides/nics/thunderx.html
> > >
> > > 2) NIC controller, based on NPU like HW accelerated coprocessors, like
> > > HW assisted mempool manager, HW assisted packet scheduler, etc
> > >
> > > This driver adds support for the second type device and which will be
> > > used as HW implementation driver ethdev-eventdev Rx adapter [1]
> > >
> > > Implemented features and PMD documentation added
> > > in doc/guides/nics/features/octeontx.ini and doc/guides/nics/octeontx.rst
> > > respectively in this patch set.
> > >
> > > This driver has the dependency on:
> > > - IOVA infrastructure [2].
> > > - Dynamically configure mempool handle (ie.. --mbuf-pool-ops eal arg) [3].
> > > - Infrastructure to support octeontx HW mempool manager [4].
> > > - Cavium Octeontx external mempool driver [5]
> > > Git source repo for all above dependency patches located at [6].
> > >
> > > The series has three check patch issues:
> > > 1) 1 Error on Complex Macro (which I believe it cannot be fixed) # Patch 2
> > > 2) 1 Error on spacing while using gcc inline assembly(it is false positive) # patch 2
> > > 3) Added Co-authored-by: signature to reflect the patch authorship status instead
> > > of "Signed-off-by". It can be changed or the contributing guide can be
> > > updated based on the community feedback in v2.
> > >
> > > [1] http://dpdk.org/dev/patchwork/patch/24176/
> > > [2] http://dpdk.org/ml/archives/dev/2017-August/072871.html
> > > [3] http://dpdk.org/ml/archives/dev/2017-August/072910.html
> > > [4] http://dpdk.org/ml/archives/dev/2017-August/072892.html
> > > [5] http://dpdk.org/ml/archives/dev/2017-August/073898.html
> > > [6] https://github.com/sshukla82/dpdk branch: mempool-v2
> > > [7] https://github.com/sshukla82/dpdk branch: octeontx-ona-pmd-v2
> > >
> > >
> > > Jerin Jacob (26):
> > > net/octeontx: add build infrastructure
> > > net/octeontx/base: add octeontx io operations
> > > event/octeontx: introduce specialized mbox message copy
> > > net/octeontx/base: add base BGX operations
> > > net/octeontx/base: add remaining BGX operations
> > > net/octeontx/base: probe PKI and PKO PCIe VF devices
> > > net/octeontx/base: add base PKI operations
> > > net/octeontx/base: add remaining PKI operations
> > > net/octeontx/base: add base PKO operations
> > > net/octeontx/base: add remaining PKO operations
> > > net/octeontx: add eth device probe and remove
> > > net/octeontx: create ethdev ports
> > > net/octeontx: add device configure
> > > net/octeontx: add device info
> > > net/octeontx: add link update
> > > net/octeontx: add promiscuous mode ops
> > > net/octeontx: add basic stats support
> > > net/octeontx: add MAC addr set op
> > > net/octeontx: add Rx queue setup and release ops
> > > net/octeontx: add Tx queue start and stop
> > > net/octeontx: add Tx queue setup and release ops
> > > net/octeontx: add packet transmit burst function
> > > net/octeontx: add packet receive burst function
> > > net/octeontx: add packet type parsing support
> > > net/octeontx: add start and stop support
> > > doc: add octeontx ethdev driver documentation
> >
> > Series applied to dpdk-next-net/master, thanks.
>
> The tree dpdk-next-net cannot be pulled in master
> because this series is breaking 32-bit compilation with debug enabled.
>
> Two comments about logs in this driver:
>
> 1/ We must not accept some DEBUG configs anymore.
> Thanks to dynamic log configuration, we can avoid such compile-time options.
> The same mistake was done for OCTEONTX mempool.
> Please remove all these DEBUG config options for 17.11-rc2.
>
> 2/ When printing a 64-bit variable, %ld or %lx is wrong.
> You must use PRId64 or PRIx64.
>
> We have two options for this patchset.
> Either the compilation is fixed and squashed today, or it is removed from RC1.
> Hope you can fix it quickly.
I will send the patches to squash it.
prev parent reply other threads:[~2017-10-11 10:59 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 14:54 [dpdk-dev] [PATCH " Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 01/26] net/octeontx: add build infrastructure Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 02/26] net/octeontx/base: add octeontx io operations Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 03/26] event/octeontx: introduce specialized mbox message copy Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 04/26] net/octeontx/base: add base BGX operations Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 05/26] net/octeontx/base: add remaining " Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 06/26] net/octeontx/base: probe PKI and PKO PCIe VF devices Jerin Jacob
2017-09-05 17:44 ` Ferruh Yigit
2017-09-11 18:27 ` Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 07/26] net/octeontx/base: add base PKI operations Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 08/26] net/octeontx/base: add remaining " Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 09/26] net/octeontx/base: add base PKO operations Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 10/26] net/octeontx/base: add remaining " Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 11/26] net/octeontx: add eth device probe and remove Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 12/26] net/octeontx: create ethdev ports Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 13/26] net/octeontx: add device configure Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 14/26] net/octeontx: add device info Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 15/26] net/octeontx: add link update Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 16/26] net/octeontx: add promiscuous mode ops Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 17/26] net/octeontx: add basic stats support Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 18/26] net/octeontx: add MAC addr set op Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 19/26] net/octeontx: add Rx queue setup and release ops Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 20/26] net/octeontx: add Tx queue start and stop Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 21/26] net/octeontx: add Tx queue setup and release ops Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 22/26] net/octeontx: add packet transmit burst function Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 23/26] net/octeontx: add packet receive " Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 24/26] net/octeontx: add packet type parsing support Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 25/26] net/octeontx: add start and stop support Jerin Jacob
2017-08-31 14:54 ` [dpdk-dev] [PATCH 26/26] doc: add octeontx ethdev driver documentation Jerin Jacob
2017-09-19 13:59 ` Mcnamara, John
2017-09-05 17:43 ` [dpdk-dev] [PATCH 00/26] DPDK PMD for OCTEONTX NW device Ferruh Yigit
2017-09-11 18:15 ` Jerin Jacob
2017-10-03 19:01 ` Ferruh Yigit
2017-10-04 5:27 ` santosh
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 " Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 01/26] net/octeontx: add build infrastructure Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 02/26] net/octeontx/base: add octeontx io operations Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 03/26] event/octeontx: introduce specialized mbox message copy Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 04/26] net/octeontx/base: add base BGX operations Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 05/26] net/octeontx/base: add remaining " Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 06/26] net/octeontx/base: probe PKI and PKO PCIe VF devices Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 07/26] net/octeontx/base: add base PKI operations Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 08/26] net/octeontx/base: add remaining " Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 09/26] net/octeontx/base: add base PKO operations Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 10/26] net/octeontx/base: add remaining " Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 11/26] net/octeontx: add eth device probe and remove Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 12/26] net/octeontx: create ethdev ports Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 13/26] net/octeontx: add device configure Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 14/26] net/octeontx: add device info Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 15/26] net/octeontx: add link update Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 16/26] net/octeontx: add promiscuous mode ops Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 17/26] net/octeontx: add basic stats support Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 18/26] net/octeontx: add MAC addr set op Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 19/26] net/octeontx: add Rx queue setup and release ops Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 20/26] net/octeontx: add Tx queue start and stop Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 21/26] net/octeontx: add Tx queue setup and release ops Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 22/26] net/octeontx: add packet transmit burst function Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 23/26] net/octeontx: add packet receive " Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 24/26] net/octeontx: add packet type parsing support Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 25/26] net/octeontx: add start and stop support Santosh Shukla
2017-10-08 12:44 ` [dpdk-dev] [PATCH v2 26/26] doc: add octeontx ethdev driver documentation Santosh Shukla
2017-10-09 2:07 ` [dpdk-dev] [PATCH v2 00/26] DPDK PMD for OCTEONTX NW device Ferruh Yigit
2017-10-09 5:12 ` santosh
2017-10-11 10:35 ` Thomas Monjalon
2017-10-11 10:58 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011105848.GA20722@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).