DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: thomas@monjalon.net
Cc: gage.eads@intel.com, santosh.shukla@caviumnetworks.com,
	bruce.richardson@intel.com, jerin.jacob@caviumnetworks.com,
	dev@dpdk.org
Subject: [dpdk-dev] [PATCH 0/3] mk: fix LDLIBS
Date: Thu, 12 Oct 2017 18:04:18 +0200	[thread overview]
Message-ID: <20171012160421.8337-1-olivier.matz@6wind.com> (raw)
In-Reply-To: <20171005125017.GA12160@bricha3-MOBL3.ger.corp.intel.com>

Some libraries in LDLIBS are currently generated from the
DEPDIRS-$(dirname) variables in the Makefiles. This is valid when the
subdirectory name match the library name, but it's not always the case,
especially for PMDs.

This series fixes some invalid dependency declarations first, and
then removes the automatic generation of libraries from the directory
names. Instead, the libraries are explicitly added in each Makefile.

Olivier Matz (3):
  crypto/dpaa2_sec: remove uneffective dependency
  mempool/octeontx: fix dependency
  mk: do not generate LDLIBS from directory dependencies

 drivers/bus/Makefile              |  2 --
 drivers/bus/dpaa/Makefile         |  2 ++
 drivers/bus/fslmc/Makefile        |  2 ++
 drivers/crypto/Makefile           | 11 -----------
 drivers/crypto/aesni_gcm/Makefile |  2 ++
 drivers/crypto/aesni_mb/Makefile  |  2 ++
 drivers/crypto/armv8/Makefile     |  2 ++
 drivers/crypto/dpaa2_sec/Makefile |  9 ++-------
 drivers/crypto/kasumi/Makefile    |  2 ++
 drivers/crypto/null/Makefile      |  2 ++
 drivers/crypto/openssl/Makefile   |  2 ++
 drivers/crypto/qat/Makefile       |  2 ++
 drivers/crypto/scheduler/Makefile |  2 ++
 drivers/crypto/snow3g/Makefile    |  2 ++
 drivers/crypto/zuc/Makefile       |  2 ++
 drivers/event/Makefile            |  4 ----
 drivers/event/dpaa2/Makefile      |  1 +
 drivers/event/octeontx/Makefile   |  1 +
 drivers/event/skeleton/Makefile   |  1 +
 drivers/event/sw/Makefile         |  1 +
 drivers/mempool/Makefile          |  5 -----
 drivers/mempool/dpaa/Makefile     |  1 +
 drivers/mempool/dpaa2/Makefile    |  1 +
 drivers/mempool/octeontx/Makefile |  4 +---
 drivers/mempool/ring/Makefile     |  1 +
 drivers/mempool/stack/Makefile    |  1 +
 drivers/net/Makefile              | 35 -----------------------------------
 drivers/net/af_packet/Makefile    |  2 ++
 drivers/net/ark/Makefile          |  2 ++
 drivers/net/avp/Makefile          |  2 ++
 drivers/net/bnx2x/Makefile        |  2 ++
 drivers/net/bnxt/Makefile         |  2 ++
 drivers/net/bonding/Makefile      |  2 ++
 drivers/net/cxgbe/Makefile        |  2 ++
 drivers/net/dpaa/Makefile         |  2 ++
 drivers/net/dpaa2/Makefile        |  2 ++
 drivers/net/e1000/Makefile        |  2 ++
 drivers/net/ena/Makefile          |  2 ++
 drivers/net/enic/Makefile         |  2 ++
 drivers/net/failsafe/Makefile     |  2 ++
 drivers/net/fm10k/Makefile        |  2 ++
 drivers/net/i40e/Makefile         |  2 ++
 drivers/net/ixgbe/Makefile        |  2 ++
 drivers/net/kni/Makefile          |  2 ++
 drivers/net/liquidio/Makefile     |  2 ++
 drivers/net/mlx4/Makefile         |  2 ++
 drivers/net/mlx5/Makefile         |  2 ++
 drivers/net/mrvl/Makefile         |  2 ++
 drivers/net/nfp/Makefile          |  2 ++
 drivers/net/null/Makefile         |  2 ++
 drivers/net/octeontx/Makefile     |  2 ++
 drivers/net/pcap/Makefile         |  2 ++
 drivers/net/qede/Makefile         |  2 ++
 drivers/net/ring/Makefile         |  2 ++
 drivers/net/sfc/Makefile          |  2 ++
 drivers/net/softnic/Makefile      |  2 ++
 drivers/net/szedata2/Makefile     |  2 ++
 drivers/net/tap/Makefile          |  2 ++
 drivers/net/thunderx/Makefile     |  2 ++
 drivers/net/vhost/Makefile        |  2 ++
 drivers/net/virtio/Makefile       |  2 ++
 drivers/net/vmxnet3/Makefile      |  2 ++
 examples/ethtool/Makefile         |  1 -
 examples/ethtool/lib/Makefile     |  1 +
 lib/Makefile                      |  5 +++--
 lib/librte_acl/Makefile           |  1 +
 lib/librte_bitratestats/Makefile  |  1 +
 lib/librte_cmdline/Makefile       |  1 +
 lib/librte_cryptodev/Makefile     |  2 ++
 lib/librte_distributor/Makefile   |  1 +
 lib/librte_efd/Makefile           |  1 +
 lib/librte_ether/Makefile         |  2 ++
 lib/librte_eventdev/Makefile      |  1 +
 lib/librte_gro/Makefile           |  1 +
 lib/librte_gso/Makefile           |  2 ++
 lib/librte_hash/Makefile          |  1 +
 lib/librte_ip_frag/Makefile       |  2 ++
 lib/librte_jobstats/Makefile      |  1 +
 lib/librte_kni/Makefile           |  1 +
 lib/librte_kvargs/Makefile        |  1 +
 lib/librte_latencystats/Makefile  |  1 +
 lib/librte_lpm/Makefile           |  1 +
 lib/librte_mbuf/Makefile          |  1 +
 lib/librte_member/Makefile        |  1 +
 lib/librte_mempool/Makefile       |  1 +
 lib/librte_meter/Makefile         |  1 +
 lib/librte_metrics/Makefile       |  1 +
 lib/librte_net/Makefile           |  1 +
 lib/librte_pdump/Makefile         |  1 +
 lib/librte_pipeline/Makefile      |  2 ++
 lib/librte_port/Makefile          |  2 ++
 lib/librte_power/Makefile         |  1 +
 lib/librte_reorder/Makefile       |  1 +
 lib/librte_ring/Makefile          |  1 +
 lib/librte_sched/Makefile         |  2 ++
 lib/librte_table/Makefile         |  2 ++
 lib/librte_timer/Makefile         |  1 +
 lib/librte_vhost/Makefile         |  1 +
 mk/rte.extsubdir.mk               |  1 -
 mk/rte.lib.mk                     |  7 -------
 mk/rte.subdir.mk                  |  3 +--
 101 files changed, 151 insertions(+), 80 deletions(-)

-- 
2.11.0

  reply	other threads:[~2017-10-12 16:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-02 20:48 [dpdk-dev] Inter-PMD dependencies when building shared libraries Eads, Gage
2017-10-05 12:12 ` Olivier MATZ
2017-10-05 12:32   ` Thomas Monjalon
2017-10-05 12:50     ` Bruce Richardson
2017-10-12 16:04       ` Olivier Matz [this message]
2017-10-12 16:04         ` [dpdk-dev] [PATCH 1/3] crypto/dpaa2_sec: remove uneffective dependency Olivier Matz
2017-10-12 16:04         ` [dpdk-dev] [PATCH 2/3] mempool/octeontx: fix dependency Olivier Matz
2017-10-12 16:04         ` [dpdk-dev] [PATCH 3/3] mk: do not generate LDLIBS from directory dependencies Olivier Matz
2017-10-24  0:11           ` Thomas Monjalon
2017-10-23 14:39         ` [dpdk-dev] [PATCH 0/3] mk: fix LDLIBS Eads, Gage
2017-10-24  0:15           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012160421.8337-1-olivier.matz@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).