From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"Chilikin, Andrey" <andrey.chilikin@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add support for raw flow type for flow director
Date: Thu, 12 Oct 2017 18:14:20 +0200 [thread overview]
Message-ID: <20171012161420.GW13551@6wind.com> (raw)
In-Reply-To: <696B43C21188DF4F9C9091AAE4789B824E2A26F5@IRSMSX108.ger.corp.intel.com>
Hi Kirill,
On Thu, Oct 12, 2017 at 11:41:50AM +0000, Rybalchenko, Kirill wrote:
> Hi Thomas,
>
> The reason this feature is needed is to be able to program custom flow types using a template packet rather than building up a C struct to define the protocol. This means that users don't have to work on the DPDK internals to support new flow types that they may be using, but can instead add them dynamically as part of their application. There are also several customers who are looking for this feature as part of the 17.11 LTS release.
>
> This patchset has been out since August and these comments are very late, with the first objections last week, which we tried to answer. This short notice doesn't allow us a reasonable amount of time to take them into account.
>
> However, to address your primary concern, we can implement this using a i40e private API, so that we are not tying users to FDIR APIs and thus not blocking the removal of the APIs in time.
>
> Ideally we would like to use rte_flow but it is based around the idea of describing packet headers which is significantly different from the proposed method using template packets. Longer term it may be possible to support this in rte_flow, we could propose this for discussion in the next release, and if there is community interest/agreement we can add it.
>
> We will rework this, in the short term, as a private API, as suggested above, and then propose an rte_flow API in the longer term. Let us know if you have any concerns about this.
I am not trying to push for its integration through rte_flow at this stage
and I don't mind the chosen PMD-specific approach, I'm just curious about
the reasons that made it hard to implement as a RTE_FLOW_ITEM_RAW thing?
(e.g. a rule with a pattern that only contains one or several such items)
Please have a look at the rte_flow_item_raw structure in rte_flow.h, tell me
what's missing in there and I'll take it into account during the next
overhaul. Thanks in advance for your feedback.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-10-12 16:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 15:30 [dpdk-dev] [PATCH 0/2] " Kirill Rybalchenko
2017-08-24 15:30 ` [dpdk-dev] [PATCH 1/2] " Kirill Rybalchenko
2017-09-04 10:35 ` Radu Nicolau
2017-08-24 15:30 ` [dpdk-dev] [PATCH 2/2] net/i40e: " Kirill Rybalchenko
2017-09-04 10:38 ` Radu Nicolau
2017-09-20 8:42 ` [dpdk-dev] [PATCH v2 0/2] ethdev: " Kirill Rybalchenko
2017-09-20 8:42 ` [dpdk-dev] [PATCH v2 1/2] " Kirill Rybalchenko
2017-09-20 8:42 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: " Kirill Rybalchenko
2017-10-03 19:02 ` [dpdk-dev] [PATCH v2 0/2] ethdev: " Ferruh Yigit
2017-10-04 16:57 ` Thomas Monjalon
2017-10-04 17:44 ` Ferruh Yigit
2017-10-04 17:56 ` Thomas Monjalon
2017-10-04 19:47 ` Ferruh Yigit
2017-10-04 22:42 ` Thomas Monjalon
2017-10-05 9:09 ` Rybalchenko, Kirill
2017-10-05 20:52 ` [dpdk-dev] [PATCH v3 0/4] " Kirill Rybalchenko
2017-10-05 20:52 ` [dpdk-dev] [PATCH v3 1/4] " Kirill Rybalchenko
2017-10-05 20:52 ` [dpdk-dev] [PATCH v3 2/4] net/i40e: " Kirill Rybalchenko
2017-10-05 20:52 ` [dpdk-dev] [PATCH v3 3/4] app/testpmd: add raw flow type to " Kirill Rybalchenko
2017-10-05 20:52 ` [dpdk-dev] [PATCH v3 4/4] doc: add description of raw flow type in flow director in testpmd Kirill Rybalchenko
2017-10-10 20:13 ` [dpdk-dev] [PATCH v4 0/4] add support for raw flow type for flow director Kirill Rybalchenko
2017-10-10 20:13 ` [dpdk-dev] [PATCH v4 1/4] ethdev: " Kirill Rybalchenko
2017-10-10 20:13 ` [dpdk-dev] [PATCH v4 2/4] net/i40e: " Kirill Rybalchenko
2017-10-10 20:13 ` [dpdk-dev] [PATCH v4 3/4] app/testpmd: add raw flow type to " Kirill Rybalchenko
2017-10-10 20:13 ` [dpdk-dev] [PATCH v4 4/4] doc: add description of raw mode in flow director in testpmd Kirill Rybalchenko
2017-10-10 20:28 ` [dpdk-dev] [PATCH v5 0/4] add support for raw flow type for flow director Kirill Rybalchenko
2017-10-10 20:28 ` [dpdk-dev] [PATCH v5 1/4] ethdev: " Kirill Rybalchenko
2017-10-11 22:26 ` Thomas Monjalon
2017-10-12 11:41 ` Rybalchenko, Kirill
2017-10-12 12:01 ` Thomas Monjalon
2017-10-12 16:14 ` Adrien Mazarguil [this message]
2017-10-10 20:28 ` [dpdk-dev] [PATCH v5 2/4] net/i40e: " Kirill Rybalchenko
2017-10-10 20:28 ` [dpdk-dev] [PATCH v5 3/4] app/testpmd: add raw flow type to " Kirill Rybalchenko
2017-10-13 3:27 ` Wu, Jingjing
2017-10-10 20:28 ` [dpdk-dev] [PATCH v5 4/4] doc: add description of raw mode in flow director in testpmd Kirill Rybalchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012161420.GW13551@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=andrey.chilikin@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=kirill.rybalchenko@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).