From: Jens Freimann <jfreimann@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, yliu@fridaylinux.org, lei.a.yao@intel.com,
thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] vhost: fetch again ring_addrs address after NUMA reallocation
Date: Fri, 13 Oct 2017 11:43:47 +0200 [thread overview]
Message-ID: <20171013094347.oq7nwfnbm3yj7zkt@dhcp-192-218.str.redhat.com> (raw)
In-Reply-To: <20171013093021.3196-1-maxime.coquelin@redhat.com>
On Fri, Oct 13, 2017 at 09:30:21AM +0000, Maxime Coquelin wrote:
>In case of NUMA reallocation, the virtqueue struct is reallocated
>on another socket, meaning that its address changes.
>
>In translate_ring_addresses(), addr pointer was not fetched again
>after the reallocation, so it pointed to freed memory.
>
>This patch just fetch again addr pointer after the reallocation.
>
>Reported-by: Yao, Lei A <lei.a.yao@intel.com>
>Tested-by: Yao, Lei A <lei.a.yao@intel.com>
>Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>---
> lib/librte_vhost/vhost_user.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
next prev parent reply other threads:[~2017-10-13 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 9:30 Maxime Coquelin
2017-10-13 9:43 ` Jens Freimann [this message]
2017-10-13 19:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013094347.oq7nwfnbm3yj7zkt@dhcp-192-218.str.redhat.com \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=lei.a.yao@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).