From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Ori Kam <orika@mellanox.com>
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations
Date: Mon, 16 Oct 2017 13:17:42 +0200 [thread overview]
Message-ID: <20171016111742.qcb2u7omvomfscgc@laranjeiro-vm> (raw)
In-Reply-To: <1508142759-24829-1-git-send-email-orika@mellanox.com>
On Mon, Oct 16, 2017 at 11:32:39AM +0300, Ori Kam wrote:
> Signed-off-by: Ori Kam <orika@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> doc/guides/nics/mlx5.rst | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index d24941a..7da5c87 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -104,7 +104,8 @@ Limitations
> -----------
>
> - Inner RSS for VXLAN frames is not supported yet.
> -- Port statistics through software counters only.
> +- Port statistics through software counters only. Flow statistics are
> + supported by hardware counters.
> - Hardware checksum RX offloads for VXLAN inner header are not supported yet.
> - Forked secondary process not supported.
> - Flow pattern without any specific vlan will match for vlan packets as well:
> @@ -127,6 +128,8 @@ Limitations
> - A multi segment packet must have less than 6 segments in case the Tx burst function
> is set to multi-packet send or Enhanced multi-packet send. Otherwise it must have
> less than 50 segments.
> +- Count action for RTE flow is only supported in OFED 4.2.
> +- Two identical rules with count action are not supported.
This last line does not bring anything, having two identical rules
already create a collision which is not defined by the flow API.
In PMD situation is is even worse, as it will match both rules and
thus it will duplicate a packet.
There is no need to add a limit on an undefined behavior by the
API itself.
Thanks,
PS: when you send a new revision, please use the --thread and
--in-reply-to to link it with the previous one.
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-10-16 11:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 8:32 Ori Kam
2017-10-16 11:17 ` Nélio Laranjeiro [this message]
2017-10-16 11:31 ` Ori Kam
2017-10-16 12:36 ` Nélio Laranjeiro
2017-10-16 13:25 ` Ori Kam
2017-10-16 14:11 ` [dpdk-dev] [PATCH v3] " Ori Kam
2017-10-16 15:19 ` Nélio Laranjeiro
2017-10-19 6:09 ` [dpdk-dev] [PATCH v4] " Ori Kam
2017-10-19 6:19 ` Ferruh Yigit
2017-10-19 6:56 ` Olga Shern
2017-10-19 7:05 ` Nélio Laranjeiro
2017-10-23 18:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016111742.qcb2u7omvomfscgc@laranjeiro-vm \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).