From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix PCI devices init
Date: Thu, 19 Oct 2017 12:22:22 +0200 [thread overview]
Message-ID: <20171019102222.GE3596@bidouze.vm.6wind.com> (raw)
In-Reply-To: <1508404312-16996-1-git-send-email-rasland@mellanox.com>
Hello Raslan,
Thanks for spotting the issue and fixing it.
Small nit below.
On Thu, Oct 19, 2017 at 12:11:52PM +0300, Raslan Darawsheh wrote:
> When trying to attach a port as a sub-device, the ethdev port
> was compared with devargs.
> In the case of a PCI device, the name in devargs is the PCI address.
> And since DPDK 17.08, the devargs name of the underlying device was
> used to match an ethdev port:
> a1e7c17555e8 ("ethdev: use device name from device structure")
>
> But the recent commit 72e3efb149cc has reverted this wrong matching
> to use the ethdev port name as identifier of the port.
> It impacts functions like rte_eth_dev_allocated() used in failsafe
> for matching ports with given devargs.
> The fix is to search for matching devargs in underlying device of
> all ethdev ports.
> If many ports match the same PCI device, only the first one is matched.
>
> This limitation was already present in previous implementation of
> rte_eth_dev_allocated(), and must be adressed later with a better
> devargs syntax.
>
> Fixes: 72e3efb149cc ("ethdev: revert use port name from device structure")
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
With the nit below fixed:
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> drivers/net/failsafe/failsafe_eal.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c
> index aeb87a0..734b25c 100644
> --- a/drivers/net/failsafe/failsafe_eal.c
> +++ b/drivers/net/failsafe/failsafe_eal.c
> @@ -41,6 +41,7 @@ fs_bus_init(struct rte_eth_dev *dev)
> struct sub_device *sdev;
> struct rte_devargs *da;
> uint8_t i;
> + uint16_t j;
> int ret;
>
> FOREACH_SUBDEV(sdev, i, dev) {
> @@ -57,7 +58,13 @@ fs_bus_init(struct rte_eth_dev *dev)
> rte_errno ? ")" : "");
> continue;
> }
> - ETH(sdev) = rte_eth_dev_allocated(da->name);
> + RTE_ETH_FOREACH_DEV(j) {
> + if (!strcmp(rte_eth_devices[j].device->name,
> + da->name)) {
The explicit comparison to 0 should be preferred, as done in
failsafe_args.c.
> + ETH(sdev) = &rte_eth_devices[j];
> + break;
> + }
> + }
> if (ETH(sdev) == NULL) {
> ERROR("sub_device %d init went wrong", i);
> return -ENODEV;
> --
> 2.7.4
>
--
Gaëtan Rivet
6WIND
prev parent reply other threads:[~2017-10-19 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 9:11 Raslan Darawsheh
2017-10-19 10:22 ` Gaëtan Rivet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019102222.GE3596@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).