From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files
Date: Thu, 19 Oct 2017 17:36:24 +0100 [thread overview]
Message-ID: <20171019163629.28618-1-bruce.richardson@intel.com> (raw)
Both Linux and BSD EALs should provide exactly the same set of functions
to the user, even if in some cases the function is a stub returning
ENOTSUP. Because of this we should only need a single version.map file for
all of EAL - not one each for Linux and FreeBSD.
Unfortunately, there was some inconsistencies in the two EALs, specifically
4 functions were missing from the BSD interrupts files. As part of adding
the needed stubs, I also discovered that there was nothing terribly
Linux-specific about the Linux-specific rte_interrupts.h file, which
appeared to contain a superset of the BSD contents. Therefore, this file
could be made common also.
The net result is that there are now zero BSD-specific EAL headers, and
only a single Linux one for KNI. The version.map file is now moved to a
common location also, just inside rte_eal directory.
[While an argument could be made to put it in common, this location works
best for integration with the existing meson build-sysetm work. It also
allows the same version file to be used for non-posix-like environments
which may not use the "common" folder as much]
Bruce Richardson (5):
eal/bsdapp: align interrupt include file with Linux version
eal/bsdapp: fix missing interrupt stub functions
eal: merge bsdapp and linuxapp interrupt headers
eal: mark internal interrupts file as such to doxygen
eal: use a single version map file
lib/librte_eal/bsdapp/eal/Makefile | 4 +-
lib/librte_eal/bsdapp/eal/eal_interrupts.c | 35 +++
.../bsdapp/eal/include/exec-env/rte_interrupts.h | 137 -----------
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 250 ---------------------
lib/librte_eal/common/Makefile | 3 +-
.../include/rte_eal_interrupts.h} | 24 +-
lib/librte_eal/common/include/rte_interrupts.h | 2 +-
lib/librte_eal/linuxapp/eal/Makefile | 4 +-
.../{linuxapp/eal => }/rte_eal_version.map | 0
9 files changed, 59 insertions(+), 400 deletions(-)
delete mode 100644 lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h
delete mode 100644 lib/librte_eal/bsdapp/eal/rte_eal_version.map
rename lib/librte_eal/{linuxapp/eal/include/exec-env/rte_interrupts.h => common/include/rte_eal_interrupts.h} (93%)
rename lib/librte_eal/{linuxapp/eal => }/rte_eal_version.map (100%)
--
2.13.6
next reply other threads:[~2017-10-19 16:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 16:36 Bruce Richardson [this message]
2017-10-19 16:36 ` [dpdk-dev] [PATCH 1/5] eal/bsdapp: align interrupt include file with Linux version Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 2/5] eal/bsdapp: fix missing interrupt stub functions Bruce Richardson
2017-10-20 9:12 ` Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 3/5] eal: merge bsdapp and linuxapp interrupt headers Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 4/5] eal: mark internal interrupts file as such to doxygen Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 5/5] eal: use a single version map file Bruce Richardson
2017-10-23 23:21 ` Thomas Monjalon
2017-10-24 9:48 ` Bruce Richardson
2017-10-19 16:45 ` [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files Bruce Richardson
2017-10-23 23:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019163629.28618-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).