From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle
Date: Sat, 21 Oct 2017 15:13:30 +0530 [thread overview]
Message-ID: <20171021094329.GA14930@jerin> (raw)
In-Reply-To: <20171020153958.10236-1-santosh.shukla@caviumnetworks.com>
-----Original Message-----
> Date: Fri, 20 Oct 2017 15:39:58 +0000
> From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> To: dev@dpdk.org
> Cc: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, Santosh Shukla
> <santosh.shukla@caviumnetworks.com>
> Subject: [PATCH v1] mempool/octeontx: remove dead code from gpool2handle
> X-Mailer: git-send-email 2.13.0
>
> Coverity Issue: 195000
> Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")
>
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> drivers/mempool/octeontx/octeontx_fpavf.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
> index 6bdfc0339..cd36a195d 100644
> --- a/drivers/mempool/octeontx/octeontx_fpavf.c
> +++ b/drivers/mempool/octeontx/octeontx_fpavf.c
> @@ -176,9 +176,6 @@ octeontx_fpa_gpool2handle(uint16_t gpool)
> RTE_ASSERT(gpool < FPA_VF_MAX);
>
> res = &fpadev.pool[gpool];
> - if (unlikely(res == NULL))
> - return 0;
> -
> return (uintptr_t)res->bar0 | gpool;
> }
>
> --
> 2.13.0
>
next prev parent reply other threads:[~2017-10-21 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 15:39 Santosh Shukla
2017-10-21 9:43 ` Jerin Jacob [this message]
2017-10-23 14:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021094329.GA14930@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=santosh.shukla@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).