From: Yuanhan Liu <yliu@fridaylinux.org>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, maxime.coquelin@redhat.com
Subject: Re: [dpdk-stable] [PATCH v2] net/virtio: fix wrong TX pkt length stats
Date: Mon, 23 Oct 2017 21:21:44 +0800 [thread overview]
Message-ID: <20171023132143.GI1545@yliu-home> (raw)
In-Reply-To: <20171023064036.56821-1-zhiyong.yang@intel.com>
On Mon, Oct 23, 2017 at 02:40:36PM +0800, Zhiyong Yang wrote:
> In the function virtqueue_enqueue_xmit(), when can_push is true,
> vtnet_hdr_size is added to pkt_len by calling rte_pktmbuf_prepend.
> So, virtio header length should be subtracted before calling stats
> function.
>
> Fixes: 58169a9c8153 ("net/virtio: support Tx checksum offload")
>
> Cc: stable@dpdk.org
> Cc: yliu@fridaylinux.org
> Cc: maxime.coquelin@redhat.com
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>
> Changes in V2:
> Put code in the function virtqueue_enqueue_xmit() according to
> yuanhan's comments.
>
> drivers/net/virtio/virtio_rxtx.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
> index 2cf82fef4..f28751e07 100644
> --- a/drivers/net/virtio/virtio_rxtx.c
> +++ b/drivers/net/virtio/virtio_rxtx.c
> @@ -396,6 +396,13 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
> vq->vq_desc_tail_idx = idx;
> vq->vq_free_cnt = (uint16_t)(vq->vq_free_cnt - needed);
> vq_update_avail_ring(vq, head_idx);
> +
> + /* when can_push is true, vtnet_hdr_size is added to pkt_len
> + * of mbuf. It should be subtracted in order to make stats function
> + * work in the right way.
> + */
> + if (can_push)
> + cookie->pkt_len -= head_size;
I actually meant to put it inside the "if (can_push)" clause, so that you
don't have to add yet another if. The another reason I wanted you to do
the move is, rte_pktmbuf_prepend (which did the magic) is exactly invoked
inside this if. Such move puts logical related code tight together. At least,
you could make the comment simpler: you don't have to say "when can_push
is true ...". Instead, it could be:
/*
* rte_pktmbuf_prepend() counts the hdr size to the pkt length,
* which is wrong. Below subtract restores the correct pkt size.
*/
--yliu
next prev parent reply other threads:[~2017-10-23 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171011043935.16813-1-zhiyong.yang@intel.com>
2017-10-23 6:40 ` Zhiyong Yang
2017-10-23 13:21 ` Yuanhan Liu [this message]
2017-10-24 2:05 ` Yang, Zhiyong
2017-10-24 3:06 ` [dpdk-stable] [PATCH v3] " Zhiyong Yang
2017-10-24 8:46 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023132143.GI1545@yliu-home \
--to=yliu@fridaylinux.org \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).