From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 5/5] eal: use a single version map file
Date: Tue, 24 Oct 2017 10:48:03 +0100 [thread overview]
Message-ID: <20171024094803.GA28136@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1544893.XYOyShJzD1@xps>
On Tue, Oct 24, 2017 at 01:21:39AM +0200, Thomas Monjalon wrote:
> 19/10/2017 18:36, Bruce Richardson:
> > Since the functions exported by DPDK EAL on all OS's should be
> > identical, we should not need separate function version files for each
> > OS. Therefore move existing version files to the top-level EAL
> > directory.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> This small change is missing and added when applying:
>
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -88,6 +88,7 @@ EAL API and common code
> F: lib/librte_eal/common/*
> F: lib/librte_eal/common/include/*
> F: lib/librte_eal/common/include/generic/
> +F: lib/librte_eal/rte_eal_version.map
> F: doc/guides/prog_guide/env_abstraction_layer.rst
> F: test/test/test_alarm.c
> F: test/test/test_atomic.c
>
Thanks, good catch.
next prev parent reply other threads:[~2017-10-24 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 16:36 [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 1/5] eal/bsdapp: align interrupt include file with Linux version Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 2/5] eal/bsdapp: fix missing interrupt stub functions Bruce Richardson
2017-10-20 9:12 ` Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 3/5] eal: merge bsdapp and linuxapp interrupt headers Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 4/5] eal: mark internal interrupts file as such to doxygen Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 5/5] eal: use a single version map file Bruce Richardson
2017-10-23 23:21 ` Thomas Monjalon
2017-10-24 9:48 ` Bruce Richardson [this message]
2017-10-19 16:45 ` [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files Bruce Richardson
2017-10-23 23:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024094803.GA28136@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).