From: Yongseok Koh <yskoh@mellanox.com>
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix adjust priority for drop queue
Date: Tue, 24 Oct 2017 10:55:03 -0700 [thread overview]
Message-ID: <20171024175502.GB20667@yongseok-MBP.local> (raw)
In-Reply-To: <8c8fb4394ba85f5bda005119cbfc851a3b728fa6.1508844772.git.nelio.laranjeiro@6wind.com>
On Tue, Oct 24, 2017 at 01:33:19PM +0200, Nelio Laranjeiro wrote:
> Drop queue should also adjust their priority according the most specific
> layer in the pattern they are matching to avoid dropping all the traffic.
>
> Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 26cf593af..549ae6916 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -1185,6 +1185,14 @@ priv_flow_convert(struct priv *priv,
> parser->queue[HASH_RXQ_ETH].ibv_attr->priority =
> attr->priority +
> hash_rxq_init[parser->layer].flow_priority;
> + } else if (parser->drop) {
Isn't this condition redundant?
And the following could be more consistent (and readable) with the similar code
above. But I'd leave it as your choice.
if (parser->drop) {
...
} else if (parser->queues_n == 1) {
...
} else {
...
}
> + /*
> + * Drop queue priority needs to be adjusted to
> + * their most specific layer priority.
> + */
> + parser->drop_q.ibv_attr->priority =
> + attr->priority +
> + hash_rxq_init[parser->layer].flow_priority;
> }
> exit_free:
> /* Only verification is expected, all resources should be released. */
> --
Thanks,
Yongseok
next prev parent reply other threads:[~2017-10-24 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 11:33 Nelio Laranjeiro
2017-10-24 17:55 ` Yongseok Koh [this message]
2017-10-25 8:06 ` Nélio Laranjeiro
2017-10-25 8:25 ` [dpdk-dev] [PATCH v2] " Nelio Laranjeiro
2017-10-25 16:41 ` Yongseok Koh
2017-10-25 21:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024175502.GB20667@yongseok-MBP.local \
--to=yskoh@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).