From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] service: add runtime service core check disable
Date: Wed, 25 Oct 2017 15:54:46 +0530 [thread overview]
Message-ID: <20171025102445.GB29948@PBHAGAVATULA-LT> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FCB780@IRSMSX102.ger.corp.intel.com>
On Wed, Oct 25, 2017 at 09:09:53AM +0000, Van Haaren, Harry wrote:
> > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Tuesday, October 24, 2017 6:25 PM
> > To: Van Haaren, Harry <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH 2/2] service: add runtime service core check disable
> >
> > On Mon, Oct 23, 2017 at 06:16:52PM +0100, Harry van Haaren wrote:
> > > This commit adds a new function to disable the runtime mapped
> > > service-cores check. This allows an application to take responsibility
> > > of running unmapped services.
> > >
> > > This feature is useful in cases like unit tests, where the application
> > > code (or unit test in this case) requires accurate control over when
> > > the service function is called to ensure correct behaviour, and when
> > > an application has an advanced use-case and wishes to manage services
> > > manually.
> > >
> >
> > Hey Harry,
> >
> > The patch looks good from a logical point of view, I have integrated this
> > with
> > 4/7 and 5/7 of the patch set [1] for removing eventdev schedule API and
> > everything
> > works well.
> >
> > My only concern is that the function name is a bit tricky to grasp. Unless
> > the
> > application(dev) knows the internal working of rte_service_runstate_get() it
> > would be a bit tricky to understand the role of
> > rte_service_set_runstate_mapped_check().
> >
> > I think we should think of a more appropriate API name for this function.
>
>
> Suggestions welcome!
>
> Otherwise I hope the documentation and unit-test usages explain the functionality ok.
>
> Cheers, -Harry
>
I think the documentation would be sufficient as I don't have a better
suggestion for the function name.
-Pavan
>
> > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> > > ---
> > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
> > > lib/librte_eal/common/include/rte_service.h | 23
> > ++++++++++++++++++++++-
> > > lib/librte_eal/common/rte_service.c | 22
> > ++++++++++++++++++++--
> > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +
> > > 4 files changed, 44 insertions(+), 3 deletions(-)
> > <snip>
> > > + * @param enabled When zero, the check is disabled. Non-zero enables the
> > check.
> > > + *
> > > + * @retval 0 Success
> > > + * @retval -EINVAL Invalid service ID
> > > + */
> > > +int32_t rte_service_set_runstate_mapped_check(uint32_t id, int32_t
> > enabled);
> > > +
> > s/enabled/enable
> > > +/**
> > > + * @warning
> > > + * @b EXPERIMENTAL: this API may change without prior notice
> > > + *
> > > * This function runs a service callback from a non-service lcore
> > context.
> > > * The *id* of the service to be run is passed in, and the service-
> > callback
> > > * is executed on the calling lcore immediately if possible. If the
> > service is
> > >
> > <snip>
> > > --
> > > 2.7.4
> > >
> >
> > Regards,
> > Pavan
Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
next prev parent reply other threads:[~2017-10-25 10:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 17:16 [dpdk-dev] [PATCH 0/2] service: enable app lcore to run service iter Harry van Haaren
2017-10-23 17:16 ` [dpdk-dev] [PATCH 1/2] service: add function for app lcore to run service Harry van Haaren
2017-10-25 10:21 ` Pavan Nikhilesh Bhagavatula
2017-10-23 17:16 ` [dpdk-dev] [PATCH 2/2] service: add runtime service core check disable Harry van Haaren
2017-10-24 17:24 ` Pavan Nikhilesh Bhagavatula
2017-10-25 9:09 ` Van Haaren, Harry
2017-10-25 10:24 ` Pavan Nikhilesh Bhagavatula [this message]
2017-10-25 13:25 ` [dpdk-dev] [PATCH v2 0/2] service: enable app lcore to run service iter Harry van Haaren
2017-10-25 13:25 ` [dpdk-dev] [PATCH v2 1/2] service: add function for app lcore to run service Harry van Haaren
2017-10-25 13:25 ` [dpdk-dev] [PATCH v2 2/2] service: add runtime service core check disable Harry van Haaren
2017-10-25 15:01 ` [dpdk-dev] [PATCH v2 0/2] service: enable app lcore to run service iter Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025102445.GB29948@PBHAGAVATULA-LT \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).