From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Ori Kam <orika@mellanox.com>
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix add counter when dev not started
Date: Mon, 30 Oct 2017 08:41:43 +0100 [thread overview]
Message-ID: <20171030074143.ietugmsvi7syaw7j@laranjeiro-vm> (raw)
In-Reply-To: <1509348744-20476-1-git-send-email-orika@mellanox.com>
On Mon, Oct 30, 2017 at 09:32:24AM +0200, Ori Kam wrote:
> When adding count action to a drop flow rule while the device was not
> stated, the counter was not saved in the flow.
>
> Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
> Cc: orika@mellanox.com
>
> Signed-off-by: Ori Kam <orika@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index f392f1f..3999b84 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -1690,13 +1690,13 @@ struct ibv_spec_header {
> ++parser->drop_q.ibv_attr->num_of_specs;
> parser->drop_q.offset += size;
> flow->drxq.ibv_attr = parser->drop_q.ibv_attr;
> + if (parser->count)
> + flow->cs = parser->cs;
> if (!priv->dev->data->dev_started)
> return 0;
> parser->drop_q.ibv_attr = NULL;
> flow->drxq.ibv_flow = ibv_create_flow(priv->flow_drop_queue->qp,
> flow->drxq.ibv_attr);
> - if (parser->count)
> - flow->cs = parser->cs;
> if (!flow->drxq.ibv_flow) {
> rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_HANDLE,
> NULL, "flow rule creation failure");
> --
> 1.7.1
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-10-30 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 7:32 Ori Kam
2017-10-30 7:41 ` Nélio Laranjeiro [this message]
2017-10-31 1:41 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030074143.ietugmsvi7syaw7j@laranjeiro-vm \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).