From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Jia He <hejianet@gmail.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com,
konstantin.ananyev@intel.com, bruce.richardson@intel.com,
jianbo.liu@arm.com, hemant.agrawal@nxp.com,
jia.he@hxt-semitech.com
Subject: Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb()
Date: Wed, 8 Nov 2017 12:47:27 +0530 [thread overview]
Message-ID: <20171108071726.GA21113@jerin> (raw)
In-Reply-To: <1510121832-16439-1-git-send-email-hejianet@gmail.com>
-----Original Message-----
> Date: Wed, 8 Nov 2017 06:17:10 +0000
> From: Jia He <hejianet@gmail.com>
> To: jerin.jacob@caviumnetworks.com, dev@dpdk.org, olivier.matz@6wind.com
> Cc: konstantin.ananyev@intel.com, bruce.richardson@intel.com,
> jianbo.liu@arm.com, hemant.agrawal@nxp.com, Jia He <hejianet@gmail.com>,
> jia.he@hxt-semitech.com
> Subject: [PATCH 1/3] eal/arm64: remove the braces {} for dmb(),dsb()
> X-Mailer: git-send-email 2.7.4
>
> for the code as follows:
> if (condition)
> rte_smp_rmb();
> else
> rte_smp_wmb();
> Without this patch, compiler will report this error:
> error: 'else' without a previous 'if'
>
> Signed-off-by: Jia He <hejianet@gmail.com>
> Signed-off-by: jia.he@hxt-semitech.com
# If both are same person then IMO, one sign-off is enough.
# Make sure the patches are ./devtools/checkpatches.sh and ./devtools/check-git-log.sh
clean
# Add Fixes: tag.
Example:
http://dpdk.org/ml/archives/dev/2017-November/081510.html
next prev parent reply other threads:[~2017-11-08 7:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 6:17 Jia He
2017-11-08 6:17 ` [dpdk-dev] [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue Jia He
2017-11-08 7:27 ` Jerin Jacob
2017-11-08 9:49 ` Ananyev, Konstantin
2017-11-08 6:17 ` [dpdk-dev] [PATCH 3/3] config: support C11 memory model for arm64 Jia He
2017-11-08 7:17 ` Jerin Jacob [this message]
2017-11-08 10:28 ` [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() Bruce Richardson
2017-11-09 1:22 ` Jia He
2017-11-09 3:14 ` Jia He
2017-11-09 3:21 ` Jianbo Liu
2017-11-09 4:43 ` Jia He
2017-11-09 4:56 ` Jianbo Liu
2017-11-09 9:38 ` Ananyev, Konstantin
2017-11-09 9:58 ` Jianbo Liu
2017-11-09 10:08 ` Ananyev, Konstantin
2017-11-10 2:06 ` Jia He
2017-11-10 3:09 ` Jianbo Liu
2017-11-10 10:06 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108071726.GA21113@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hejianet@gmail.com \
--cc=hemant.agrawal@nxp.com \
--cc=jia.he@hxt-semitech.com \
--cc=jianbo.liu@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).