DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: junjie.j.chen@intel.com
Cc: sergio.gonzalez.monroy@intel.com, john.mcnamara@intel.com,
	maryam.tahhan@intel.com, reshma.pattan@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: add a restriction to multi-process support
Date: Tue, 28 Nov 2017 11:22:24 +0000	[thread overview]
Message-ID: <20171128112224.GA5724@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20171128095654.6452-1-junjie.j.chen@intel.com>

On Tue, Nov 28, 2017 at 04:56:54AM -0500, junjie.j.chen@intel.com wrote:
> From: Junjie Chen <junjie.j.chen@intel.com>
> 
> This patch add a restriction to multi-process support: secondary
> processes should only run alongside primary process with same DPDK 
> version, so that secondary processes can use the same hugepage mmap
> layout as primary process.
> 
> Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> ---
>  doc/guides/prog_guide/multi_proc_support.rst | 1 +
>  doc/guides/tools/proc_info.rst               | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst
> index 9a9dca7fe..0cd67ae2d 100644
> --- a/doc/guides/prog_guide/multi_proc_support.rst
> +++ b/doc/guides/prog_guide/multi_proc_support.rst
> @@ -51,6 +51,7 @@ For now, there are two types of process specified:
>  Standalone DPDK processes are primary processes,
>  while secondary processes can only run alongside a primary process or
>  after a primary process has already configured the hugepage shared memory for them.
> +And secondary processes should only run alongside primary process with same DPDK version.
>  
>  To support these two process types, and other multi-process setups described later,
>  two additional command-line parameters are available to the EAL:
> diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.rst
> index fd17e278c..512fd3263 100644
> --- a/doc/guides/tools/proc_info.rst
> +++ b/doc/guides/tools/proc_info.rst
> @@ -36,7 +36,8 @@ The dpdk-procinfo application is a Data Plane Development Kit (DPDK) application
>  that runs as a DPDK secondary process and is capable of retrieving port
>  statistics, resetting port statistics and printing DPDK memory information.
>  This application extends the original functionality that was supported by
> -dump_cfg.
> +dump_cfg. Note that dpdk-procinfo can only run alongside primary process with 
> +same DPDK version.
>  
>  Running the Application
>  -----------------------
> -- 
Good to add to the docs. I suggest that you add them using the proper
"note" markup to make it clearer in the docs.

/Bruce

  reply	other threads:[~2017-11-28 11:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28  9:56 junjie.j.chen
2017-11-28 11:22 ` Bruce Richardson [this message]
2017-11-29  9:38   ` Chen, Junjie J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128112224.GA5724@bricha3-MOBL3.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=junjie.j.chen@intel.com \
    --cc=maryam.tahhan@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).